nautobot / nautobot-app-golden-config

Golden Configuration App for Nautobot.
https://docs.nautobot.com/projects/golden-config/en/latest/
Other
100 stars 57 forks source link

Consider proper pattern for job approvals when model itself exposes a status/approval. #720

Open jeffkala opened 9 months ago

jeffkala commented 9 months ago

Have a pattern to warn users of not using job-approvals when a model (config deployments) already exposes a way to approve/deny model instances. Steps to recreate:

Create a ConfigPlan Redirects to the job approval page. Change user, approve the job Click "continue" on popup about job being immediatly executed. Got to job result and notice the configplan "self" logic actually resulted in the job not running due to

 ['`E3025:` Cannot deploy configuration(s). One or more config plans are not approved.']}