nautobot / nautobot-app-golden-config

Golden Configuration App for Nautobot.
https://docs.nautobot.com/projects/golden-config/en/latest/
Other
100 stars 57 forks source link

Create filter so Config Compliance tab is not shown on non-network devices #723

Closed jedelman8 closed 5 months ago

jedelman8 commented 8 months ago

Proposed Functionality

Limit the devices that the the "Configuration Compliance" tab is shown on. Allow a setting to selectively apply that tab based on device type, manufacturer, or role. It may be helpful to support negations, e.g. do not apply it on PDUs (as one example). Or only show when devices are actively in scope for GC.

itdependsnetworks commented 8 months ago

This Or only show when devices are actively in scope for GC. has been discussed in the past and I think reasonable.

mzbroch commented 7 months ago

This Or only show when devices are actively in scope for GC. has been discussed in the past and I think reasonable.

There are two ways to implement this :

itdependsnetworks commented 7 months ago

We have mostly gone down this route at this point: rely on existing complianceResults. Would require compliance job to be executed first, only then, tab would appear. it doesn't show otherwise and you get a banner to remind you to run the job to create the ComplianceResults object regardless if empty.