search

nautobot / nautobot-app-golden-config

Golden Configuration App for Nautobot.
https://docs.nautobot.com/projects/golden-config/en/latest/
Other
100 stars 57 forks source link

Fix Compliance Not Running #750

Closed jdrew82 closed 7 months ago

jdrew82 commented 7 months ago

This PR addresses the issue mentioned in #749. After some investigation it was found that any Exceptions being thrown during one of the Jobs will cause consecutive Golden Config tasks to never be ran. It was also found that Exceptions weren't being logged or bubbled up to be handled appropriately. This PR resolves all of those issues and attempts to log failures in a much more user friendly manner. It allows for generalized Exceptions to be raised and cause a Job to be failed like expected. It also includes a refactoring of the config_* functions to all work by just passing the Job itself so they have a standardized interface.

itdependsnetworks commented 7 months ago

Can you add Numbered messages to all of the places there is errors so we can build a tracking system of what issues are likely to show there.

It was also found that Exceptions weren't being logged or bubbled up to be handled appropriately

Would you help explain this, otherwise the past is destined to repeat.