search

nautobot / nautobot-app-secrets-providers

Nautobot Secrets Providers Plugin.
Other
17 stars 15 forks source link

Add Azure Key Vault secrets provider #126

Closed JonathanNathanson closed 4 months ago

JonathanNathanson commented 8 months ago

I'll open this with saying this is the first time I've ever contributed to an open source project, including this Nautobot app. So, if I've done anything wrong, apologies in advance and just let me know how do it correctly in future.

I have a need to use Azure Key Vault as a secrets provider in my own deployment, and given the existing issue on the matter (#20) hasn't received any traction for a while, I figured I'd have a go at building it myself.

I haven't built any tests for the code as yet, but open to looking into that as a next step.

gsnider2195 commented 8 months ago

Thank you for the submission! This looks great so far, but it will take us a bit to get an environment set up to test it locally and give you feedback. One question I have is why the minimum Nautobot version was bumped up to ^2.1.5?

JonathanNathanson commented 8 months ago

One question I have is why the minimum Nautobot version was bumped up to ^2.1.5?

That's a mistake from early on when I was figuring out the development environment, should have been discarded before my commit. I've pushed another to revert that back.

DistantVoyager commented 4 months ago

@glennmatthews ready for review. This is just to merge the forked branch into a new working branch https://github.com/nautobot/nautobot-app-secrets-providers/tree/azure-provider-branch where I'll make some minor edits and add additional docs