nautobot / nautobot-app-ssot

Single Source of Truth for Nautobot
https://docs.nautobot.com/projects/ssot/en/latest/
Other
37 stars 35 forks source link

AssertionError at /graphql/ #274

Closed Danmanny closed 10 months ago

Danmanny commented 11 months ago

Environment

Work in a Nautobot v2.0.0 environment and access graphql.

Cannot access graphql

Names must match /^[_a-zA-Z][_a-zA-Z0-9]*$/ but "cf_ssot-synced-from-ipfabric" does not.
Request Method: | GET -- | -- http://nautobot203.x.x.x/graphql/ 3.2.21 AssertionError Names must match /^[_a-zA-Z][_a-zA-Z0-9]*$/ but "cf_ssot-synced-from-ipfabric" does not. /usr/local/lib/python3.10/site-packages/graphql/utils/assert_valid_name.py, line 10, in assert_valid_name /usr/local/bin/python3.10 3.10.13 ['.', '', '/opt/nautobot', '/usr/local/lib/python3.10/site-packages/git/ext/gitdb', '/usr/local/bin', '/usr/local/lib/python310.zip', '/usr/local/lib/python3.10', '/usr/local/lib/python3.10/lib-dynload', '/opt/nautobot/.local/lib/python3.10/site-packages', '/usr/local/lib/python3.10/site-packages', '/opt/nautobot/jobs', '/opt/nautobot/git'] Wed, 15 Nov 2023 16:12:32 +0000


-->
### Steps to Reproduce
1. Install Nautobot 2.0.0
2. Access Graphql
jdrew82 commented 11 months ago

Investigated this and it appears to be related to some of the CustomFields being created in various integration signals. A few have dashes in the key when dashes will break GraphQL. CustomFields should always use underscores in keys.

jeffkala commented 11 months ago

Hit this as well with infoblox.

AssertionError: Names must match /^[_a-zA-Z][_a-zA-Z0-9]*$/ but "cf_ssot-synced-to-infoblox" does not.

jdrew82 commented 11 months ago

Hit this as well with infoblox.

AssertionError: Names must match /^[_a-zA-Z][_a-zA-Z0-9]*$/ but "cf_ssot-synced-to-infoblox" does not.

That's been found and is addressed in the fix PR.

Kircheneer commented 11 months ago

@jdrew82 does #275 cover all of these?

jdrew82 commented 11 months ago

Yes, I tried to make sure I covered all CustomFields created by integrations.

jdrew82 commented 10 months ago

This should be resolved now so closing.