search

nautobot / nautobot-app-ssot

Single Source of Truth for Nautobot
https://docs.nautobot.com/projects/ssot/en/latest/
Other
37 stars 35 forks source link

Use full names on interfaces with ipfabric #307

Closed itdependsnetworks closed 9 months ago

itdependsnetworks commented 10 months ago

Environment

Proposed Functionality

Use full names on interfaces with ipfabric

Here: https://github.com/nautobot/nautobot-plugin-ssot/blob/2a0f24d0612cbe934629d666a4ef9113cfa9e71b/nautobot_ssot/integrations/ipfabric/diffsync/adapter_nautobot.py#L96C11-L96C11

                from netutils.interface import canonical_interface_name
                name=canonical_interface_name(interface_record.name),

Use Case

Names correct to match configuration

Kircheneer commented 10 months ago

Seems like a breaking change to me. This raises the interesting question of whether all breaking changes in integrations warrant a major release, I would say so personally.

jdrew82 commented 10 months ago

Seems like a breaking change to me. This raises the interesting question of whether all breaking changes in integrations warrant a major release, I would say so personally.

If we're following SemVer technically breaking changes should absolutely warrant a major release.