nautobot / nautobot-app-ssot

Single Source of Truth for Nautobot
https://docs.nautobot.com/projects/ssot/en/latest/
Other
34 stars 28 forks source link

Syncing from Cloudvision - get_devices without the import_active argument #463

Closed etiennelatulippe closed 4 weeks ago

etiennelatulippe commented 4 weeks ago

Environment

What did you expect to happen?

Being able to sync from Cloudvision

What happened instead?

The job got an error using get_devices because it is called without the import_active argument.

{
"exc_message":[
"get_devices() missing 1 required argument: 'import_active'"
]
"exc_module": "builtins",
"exc_type": "TypeError"
}

https://github.com/nautobot/nautobot-app-ssot/blob/develop/nautobot_ssot/integrations/aristacv/diffsync/adapters/cloudvision.py#L72

https://github.com/nautobot/nautobot-app-ssot/blob/develop/nautobot_ssot/integrations/aristacv/utils/cloudvision.py#L256

Steps to Reproduce

  1. Go on the Cloudvision SSOT sync job
  2. Start the job
  3. Get the error
etiennelatulippe commented 4 weeks ago

The #464 is fixing the issue. Thank you!