ACI Sync Job fails with TypeError: 'str' object is not callable

[kingfetty]

Environment

• Python version: 3.10.12
• Nautobot version: 2.2.7
• nautobot-ssot version: 2.6.1

Expected Behavior

Expected to synchronize data from ACI fabric to NB instance

Observed Behavior

Running the job connects to the ACI APIC and starts to pull data, upon reaching the load_devices code errors with the below stack trace:

`Traceback (most recent call last): File "/opt/nautobot/lib/python3.10/site-packages/diffsync/store/init.py", line 155, in get_or_instantiate obj = self.get(model=model, identifier=ids) File "/opt/nautobot/lib/python3.10/site-packages/diffsync/store/local.py", line 49, in get raise ObjectNotFound(f"{modelname} {uid} not present in {str(self)}") diffsync.exceptions.ObjectNotFound: device_type N9K-C93180YC-FX3__ not present in LocalStore

During handling of the above exception, another exception occurred:

Traceback (most recent call last): File "/opt/nautobot/lib/python3.10/site-packages/celery/app/trace.py", line 477, in trace_task R = retval = fun(*args, kwargs) File "/opt/nautobot/lib/python3.10/site-packages/celery/app/trace.py", line 760, in __protected_call__ return self.run(*args, *kwargs) File "/opt/nautobot/lib/python3.10/site-packages/nautobot/extras/jobs.py", line 1136, in run_job result = job(args, kwargs) File "/opt/nautobot/lib/python3.10/site-packages/nautobot/extras/jobs.py", line 149, in call return self.run(*args, *deserialized_kwargs) File "/opt/nautobot/lib/python3.10/site-packages/nautobot_ssot/integrations/aci/jobs.py", line 90, in run super().run(dryrun=self.dryrun, memory_profiling=self.memory_profiling, args, kwargs) File "/opt/nautobot/lib/python3.10/site-packages/nautobot_ssot/jobs/base.py", line 317, in run self.sync_data(memory_profiling) File "/opt/nautobot/lib/python3.10/site-packages/nautobot_ssot/jobs/base.py", line 136, in sync_data self.load_source_adapter() File "/opt/nautobot/lib/python3.10/site-packages/nautobot_ssot/integrations/aci/jobs.py", line 75, in load_source_adapter self.source_adapter.load() File "/opt/nautobot/lib/python3.10/site-packages/nautobot_ssot/integrations/aci/diffsync/adapters/aci.py", line 438, in load self.load_devices() File "/opt/nautobot/lib/python3.10/site-packages/nautobot_ssot/integrations/aci/diffsync/adapters/aci.py", line 412, in load_devices self.get_or_instantiate( File "/opt/nautobot/lib/python3.10/site-packages/diffsync/init.py", line 813, in get_or_instantiate return self.store.get_or_instantiate(model=model, ids=ids, attrs=attrs) File "/opt/nautobot/lib/python3.10/site-packages/diffsync/store/init.py", line 159, in get_or_instantiate obj = model(ids, **attrs) TypeError: 'str' object is not callable`

Steps to Reproduce

Create nautobot install Ensure SSOT[ACI] is installed and properly loaded with correct environmental variables Enable sync job Execute sync job against controller.

Suspected Cause

Within the plugin code for the ACI adapter load_devices() is calling self.get_or_instantiate() passing a string in of "device_type" for the model argument. Further in the code, diffsync is attempting to execute whatever this argument is as a method. Given that string types are not callable it throws the error. I suspect that get_or_instantiate is being called with incorrect argument as the "model" argument.

[kingfetty]

After the correction of using a string to using self.device_type the code now fails at load_interfaces() because there is a block attempting to read the variable device_specs before it is assigned. This is due to the fact that the variable is created inside an if block that checks if a yaml file exists and the reference to the variable is outside this if block.

[kingfetty]

Also appears Sync Job is using default soft timeout limit of 5 minutes which is way too short for a sync job. This should be updated in the jobs.py meta to be at least several hours.

[ShivaniMauryaIntel]

I had the same issue. If the issue is fixed, do we need to reinstall the ssot plugin ?

[ShivaniMauryaIntel]

@jdrew82 I have reinstalled the ssot plugin & ran the aci sync job again. The job is still failing & a new error is coming now - "exc_message": [ "ltd"] where "ltd" is the identifier used in my env variable. If I replace ltd with abc or any other name, that name will be the error. Below are the env vars used - NAUTOBOT_APIC_BASEURILTD NAUTOBOT_APICUSERNAMELTD NAUTOBOT_APICPASSWORDLTD NAUTOBOT_APICVERIFYLTD NAUTOBOT_APICSITELTD NAUTOBOT_APIC_TENANTPREFIXLTD

[jdrew82]

@ShivaniMauryaIntel can you provide the full traceback? Without knowing where this is happening it's tough to track down the cause.

[jdrew82]

Also appears Sync Job is using default soft timeout limit of 5 minutes which is way too short for a sync job. This should be updated in the jobs.py meta to be at least several hours.

The global timeout is defined with the NAUTOBOT_CELERY_TASK_SOFT_TIME_LIMIT and NAUTOBOT_CELERY_TASK_TIME_LIMIT environment variables as hard limits. You can go into the Job settings and set a lower timeout if desired. Although we can set one in the Job itself it's difficult to know an appropriate timeout as it will vary quite a bit depending upon your deployment size and size of dataset being imported.

[ShivaniMauryaIntel]

@jdrew82 Based on your suggestion on slack, I have defined my env vars in a .env file & called the file in nautobot service - https://josh-v.com/nautobot-environment-file/ Below are the env vars used - NAUTOBOT_APIC_BASE_URI_LTD NAUTOBOT_APIC_USERNAME_LTD NAUTOBOT_APIC_PASSWORD_LTD NAUTOBOT_APIC_VERIFY_LTD NAUTOBOT_APIC_SITE_LTD NAUTOBOT_APIC_TENANT_PREFIX_LTD

Now, I am running the ACI sync job from Nautobot UI & I am getting the error at "ltd" which is the identifier used in my env variable. If I replace ltd with abc or any other name, that name is showing in the error message - Return Data - { "exc_message": [ "ltd" ], "exc_module": "builtins", "exc_type": "KeyError" }

Traceback (most recent call last): File "/opt/nautobot/lib64/python3.9/site-packages/celery/app/trace.py", line 477, in trace_task R = retval = fun(*args, kwargs) File "/opt/nautobot/lib64/python3.9/site-packages/celery/app/trace.py", line 760, in __protected_call__ return self.run(*args, *kwargs) File "/opt/nautobot/lib64/python3.9/site-packages/nautobot/extras/jobs.py", line 1136, in run_job result = job(args, kwargs) File "/opt/nautobot/lib64/python3.9/site-packages/nautobot/extras/jobs.py", line 149, in call return self.run(*args, *deserialized_kwargs) File "/opt/nautobot/lib64/python3.9/site-packages/nautobot_ssot/integrations/aci/jobs.py", line 90, in run super().run(dryrun=self.dryrun, memory_profiling=self.memory_profiling, args, **kwargs) File "/opt/nautobot/lib64/python3.9/site-packages/nautobot_ssot/jobs/base.py", line 317, in run self.sync_data(memory_profiling) File "/opt/nautobot/lib64/python3.9/site-packages/nautobot_ssot/jobs/base.py", line 136, in sync_data self.load_source_adapter() File "/opt/nautobot/lib64/python3.9/site-packages/nautobot_ssot/integrations/aci/jobs.py", line 74, in load_source_adapter self.source_adapter = AciAdapter(job=self, sync=self.sync, client=aci_creds[self.apic]) KeyError: 'ltd'

[ShivaniMauryaIntel]

@jdrew82 Is this issue raised as another bug with ACI Sync Job? I am a bit concerned here as there was a bug fixed in the ACI Sync job 2 weeks ago & now there is another bug.

[jdrew82]

@ShivaniMauryaIntel @kingfetty Can you confirm if this has been resolved with the recent updates to the ACI integration?

[ShivaniMauryaIntel]

@jdrew82 I will test this in couple of days & will let you know.