search

nautobot / nautobot-app-ssot

Single Source of Truth for Nautobot
https://docs.nautobot.com/projects/ssot/en/latest/
Other
38 stars 41 forks source link

Update variable used in Dryrun job decision #549

Closed qduk closed 1 month ago

qduk commented 2 months ago

This changes the variable looked at for dryrun to be self.sync.dry_run instead of self.dryrun.

I can pull out the format changes if need be.

gsnider2195 commented 2 months ago

Are you still using black for formatting? It looks like your autoformatter has defaulted to 100 character line-width which is creating a bunch of noise. There's a bug in the ruff-format ci check that causes it to always pass but ruff formatting is actually failing if you look at https://github.com/nautobot/nautobot-app-ssot/actions/runs/10890864505/job/30220509988?pr=549

qduk commented 1 month ago

@gsnider2195 I've gone and fixed ruff. I had a unittest failing as well but I've gone and resolved that.

gsnider2195 commented 1 month ago

@gsnider2195 I've gone and fixed ruff. I had a unittest failing as well but I've gone and resolved that.

Ruff is still complaining about one file:

Would reformat: nautobot_ssot/jobs/base.py

qduk commented 1 month ago

@gsnider2195 I've gone and fixed ruff. I had a unittest failing as well but I've gone and resolved that.

Ruff is still complaining about one file:

Would reformat: nautobot_ssot/jobs/base.py

Now it's "ruffed". Thanks Gary!