search

nautobot / nautobot-app-version-control

Version Control App that uses and requires a Dolt Database
Other
30 stars 6 forks source link

Update Development Container to Use Celery #130

Closed jvanderaa closed 2 years ago

jvanderaa commented 2 years ago

Attempting to fix #128 .

@tim-fiola I was not able to recreate the issue based on the notes. I think this fixes the issue based on the conversation. Can you test and approve?

tim-fiola commented 2 years ago

I will test this early next week. Thank you!

tim-fiola commented 2 years ago

I tested this with the same webhook configured in #128 . The webhook did not fire when I modified a device

invoke debug output for when I modified a device; there is no webhook firing when the device is updated:

nautobot_1  | [01/Nov/2021 21:04:33] "GET /health/ HTTP/1.1" 201 0
dolt_1      | 2021-11-01T21:04:34Z INFO [conn 99] NewConnection {}
dolt_1      | 2021-11-01T21:04:34Z INFO [conn 100] NewConnection {}
nautobot_1  | [01/Nov/2021 21:04:37] "POST /dcim/devices/296d76f6-5925-43d3-afa0-05b3d72515be/edit/ HTTP/1.1" 302 0
dolt_1      | 2021-11-01T21:04:37Z INFO [conn 100] ConnectionClosed {}
dolt_1      | 2021-11-01T21:04:37Z INFO [conn 99] ConnectionClosed {}
dolt_1      | 2021-11-01T21:04:37Z INFO [conn 101] NewConnection {}
dolt_1      | 2021-11-01T21:04:37Z INFO [conn 102] NewConnection {}
nautobot_1  | [01/Nov/2021 21:04:39] "GET /health/ HTTP/1.1" 201 0
nautobot_1  | [01/Nov/2021 21:04:39] "GET /dcim/devices/296d76f6-5925-43d3-afa0-05b3d72515be/ HTTP/1.1" 200 217948
dolt_1      | 2021-11-01T21:04:39Z INFO [conn 102] ConnectionClosed {}
dolt_1      | 2021-11-01T21:04:39Z INFO [conn 101] ConnectionClosed {}
nautobot_1  | [01/Nov/2021 21:04:44] "GET /health/ HTTP/1.1" 201 0
nautobot_1  | [01/Nov/2021 21:04:49] "GET /health/ HTTP/1.1" 201 0
tim-fiola commented 2 years ago

@jvanderaa. This works. Sorry for the misfires prior. Thank you!

dolt_1      | 2021-11-02T15:39:40Z INFO [conn 56] NewConnection {}
worker_1    | [2021-11-02 15:39:40,303: INFO/ForkPoolWorker-6] Sending POST request to https://hooks.slack.com/services/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 (pullrequestreview created)
worker_1    | [2021-11-02 15:39:40,605: INFO/ForkPoolWorker-6] Request succeeded; response status 200
worker_1    | [2021-11-02 15:39:40,607: INFO/ForkPoolWorker-6] Task nautobot.extras.tasks.process_webhook[feab14a9-ad63-4a2a-be50-be0993f8b77c] succeeded in 0.3413488999940455s: 'Status 200 returned, webhook successfully processed.'
dolt_1      | 2021-11-02T15:39:40Z INFO [conn 56] ConnectionClosed {}
nautobot_1  | [02/Nov/2021 15:39:40] "POST /plugins/dolt/pull-request/c43420a4-c749-49d1-bf81-09865bda47d3/reviews/add/ HTTP/1.1" 302 0
jvanderaa commented 2 years ago

This should be good to merge then. @tim-fiola