Commits tab shows 'nautobot' as committer, even when a different user makes the commit

[tim-fiola]

When a user that does not have a username of nautobot makes a change, the Version Control --> Commits entries always show the committer as nautobot

One of the advantages that the Commits view brings, especially to the main branch, is that it offers an auditable history of changes to the production data: who made what change and when. However, if the Committer always shows as nautobot, this makes the Commits history much less valuable

In this example below, as user tim, I made the most recent (top) change in the list, but the Committer shows as nautobot

To replicate:

• In any branch, make a change
• Go to Version Control --> Commits
• Note the Committer will show up as nautobot

[glennmatthews]

Strangely I don't see this in a local dev environment with user "admin", but do with user "ntc":

[glennmatthews]

Looks like this is due to logic in author_from_user - it defaults to nautobot <nautobot@ntc.com> if the provided user doesn't have an email address on record.