search

nautobot / nautobot-app-version-control

Version Control App that uses and requires a Dolt Database
Other
29 stars 6 forks source link

Cookie initialy baked by NetworkToCode Cookie Drift Manager Tool #210

Closed snaselj closed 3 weeks ago

snaselj commented 4 months ago

Template:

{
    "template": "https://github.com/nautobot/cookiecutter-nautobot-app.git",
    "dir": "nautobot-app",
    "ref": "develop",
    "path": null
}

Cookie:

{
    "remote": "https://github.com/nautobot/nautobot-app-version-control.git",
    "path": "/opt/ntc/drift-manager/outputs/nautobot-app-version-control",
    "repository_path": "/opt/ntc/drift-manager/outputs/nautobot-app-version-control",
    "dir": "",
    "branch_prefix": "drift-manager",
    "context": {
        "codeowner_github_usernames": "@smith-ntc",
        "full_name": "Network to Code, LLC",
        "email": "opensource@networktocode.com",
        "github_org": "nautobot",
        "app_name": "nautobot_version_control",
        "verbose_name": "Nautobot Version Control",
        "app_slug": "nautobot-version-control",
        "project_slug": "nautobot-app-version-control",
        "repo_url": "https://github.com/nautobot/nautobot-app-version-control",
        "base_url": "version-control",
        "min_nautobot_version": "2.0.3",
        "max_nautobot_version": "2.9999",
        "camel_name": "NautobotVersionControl",
        "project_short_description": "Nautobot Version Control with Dolt",
        "model_class_name": "None",
        "open_source_license": "Apache-2.0",
        "docs_base_url": "https://docs.nautobot.com",
        "docs_app_url": "https://docs.nautobot.com/projects/version-control/en/latest",
        "_template": "https://github.com/nautobot/cookiecutter-nautobot-app.git",
        "_output_dir": "/opt/ntc/drift-manager/outputs",
        "_repo_dir": "/opt/ntc/drift-manager/outputs/.cookiecutters/cookiecutter-nautobot-app/nautobot-app",
        "_checkout": "develop"
    },
    "base_branch": "develop",
    "remote_name": "origin",
    "pull_request_strategy": "PullRequestStrategy.CREATE",
    "post_actions": [
        "PostAction.BLACK"
    ],
    "baked_commit_ref": "",
    "draft": true
}

CLI Arguments:

{
    "cookie_dir": "",
    "input": false,
    "json_filename": "json/version-control.json",
    "output_dir": "./outputs",
    "push": true,
    "template": "https://github.com/nautobot/cookiecutter-nautobot-app.git",
    "template_dir": "nautobot-app",
    "template_ref": "develop",
    "pull_request": null,
    "post_action": [
        "black"
    ],
    "disable_post_actions": false,
    "draft": true
}
snaselj commented 4 months ago

This pull request has been cleaned up and is ready for the review. @itdependsnetworks

itdependsnetworks commented 4 months ago

I think this is good...

itdependsnetworks commented 4 months ago

As @glennmatthews has mentioned, leaving the mysql / postgres will be counter productive. The issue is that it will leave the user with the understanding that this will work with one of them.

snaselj commented 4 months ago

As @glennmatthews has mentioned, leaving the mysql / postgres will be counter productive. The issue is that it will leave the user with the understanding that this will work with one of them.

My opinion is that we should rather customize the template over doing manual changes here. WDYT @cmsirbu @whitej6