search

nautobot / nautobot-plugin-chatops-ipfabric

IP Fabric ChatOps
Other
11 stars 6 forks source link

v5.0 Changes #109

Closed ghost closed 2 years ago

whitej6 commented 2 years ago

@pke11y can you pin flake8 to fix the linting issue? Below is what we do in golden config for that issue in the pyproject.toml.

# we need to pin flake8 because of package dependencies that cause it to downgrade and 
# therefore cause issues with linting since older versions do not take .flake8 as config
flake8 = "^3.9.2"
pke11y commented 2 years ago

@whitej6 great, thanks for the info

ghost commented 2 years ago

We are working on many new updates to 5.0 package. Will hopefully continue working on this next week.

whitej6 commented 2 years ago

@justinjeffery-ipf is this ready for final review & merge? If so I will pull down and run a local instance to test.

ghost commented 2 years ago

@justinjeffery-ipf is this ready for final review & merge? If so I will pull down and run a local instance to test.

Yes however this will only work with IP Fabric version 5.0, all support for 4.4 was dropped.

pke11y commented 2 years ago

@justinjeffery-ipf what's the incompatibility with v4 - the API URL? I'm okay with moving to only supporting v5 on the next release. We'd just need to test to verify all is working okay.

chadell commented 2 years ago

I support a clear deprecation policy, something like we are doing in https://github.com/nautobot/nautobot-plugin-golden-config/blob/develop/docs/admin/admin_install.md#deprecation-policy

ghost commented 2 years ago

Table PR till Friday's meeting?

whitej6 commented 2 years ago

Should I be on that call?

pke11y commented 2 years ago

Should I be on that call?

@whitej6 will sync with you offline on this.