nautobot / nautobot

Network Source of Truth & Network Automation Platform
https://docs.nautobot.com
Apache License 2.0
943 stars 254 forks source link

[2.3] 'Configure' button for adjusting Device Interface fields does nothing #5818

Open nrnvgh opened 1 week ago

nrnvgh commented 1 week ago

Environment

Steps to Reproduce

  1. Navigate to a device which has interfaces on https://next.demo.nautobot.com/ (e.g. This one)
  2. Attempt to click this button: Screenshot 2024-06-14 at 2 52 44 PM

Expected Behavior

The appearance of the modal "Table Configuration" box, such as this example taken from demo.nautobot.com Screenshot 2024-06-14 at 3 02 56 PM

Observed Behavior

Nothing happens. Additionally, using the browser's Web Developer Tools, no request appears to be made when the button is clicked.

Per discussion in Slack:

Glenn M 9 minutes ago button has data-target="#DeviceInterfaceTable_config" but the table is now id="DeviceModuleInterfaceTable_config"

glennmatthews commented 1 week ago

Appears to have been introduced by #5724's renaming of many Device-related tables. Probably all of the below need to be corrected:

nautobot/dcim/templates/dcim/device/consoleports.html:                        <button type="button" class="btn btn-default btn-xs" data-toggle="modal" data-target="#DeviceConsolePortTable_config" title="Configure table"><i class="mdi mdi-cog"></i> Configure</button>
nautobot/dcim/templates/dcim/device/consoleserverports.html:                        <button type="button" class="btn btn-default btn-xs" data-toggle="modal" data-target="#DeviceConsoleServerPortTable_config" title="Configure table"><i class="mdi mdi-cog"></i> Configure</button>
nautobot/dcim/templates/dcim/device/devicebays.html:                        <button type="button" class="btn btn-default btn-xs" data-toggle="modal" data-target="#DeviceDeviceBayTable_config" title="Configure table"><i class="mdi mdi-cog"></i> Configure</button>
nautobot/dcim/templates/dcim/device/frontports.html:                        <button type="button" class="btn btn-default btn-xs" data-toggle="modal" data-target="#DeviceFrontPortTable_config" title="Configure table"><i class="mdi mdi-cog"></i> Configure</button>
nautobot/dcim/templates/dcim/device/interfaces.html:                        <button type="button" class="btn btn-default btn-xs" data-toggle="modal" data-target="#DeviceInterfaceTable_config" title="Configure table"><i class="mdi mdi-cog"></i> Configure</button>
nautobot/dcim/templates/dcim/device/inventory.html:                        <button type="button" class="btn btn-default btn-xs" data-toggle="modal" data-target="#DeviceInventoryItemTable_config" title="Configure table"><i class="mdi mdi-cog"></i> Configure</button>
nautobot/dcim/templates/dcim/device/modulebays.html:                        <button type="button" class="btn btn-default btn-xs" data-toggle="modal" data-target="#DeviceModuleBayTable_config" title="Configure table"><i class="mdi mdi-cog"></i> Configure</button>
nautobot/dcim/templates/dcim/device/poweroutlets.html:                        <button type="button" class="btn btn-default btn-xs" data-toggle="modal" data-target="#DevicePowerOutletTable_config" title="Configure table"><i class="mdi mdi-cog"></i> Configure</button>
nautobot/dcim/templates/dcim/device/powerports.html:                        <button type="button" class="btn btn-default btn-xs" data-toggle="modal" data-target="#DevicePowerPortTable_config" title="Configure table"><i class="mdi mdi-cog"></i> Configure</button>
nautobot/dcim/templates/dcim/device/rearports.html:                        <button type="button" class="btn btn-default btn-xs" data-toggle="modal" data-target="#DeviceRearPortTable_config" title="Configure table"><i class="mdi mdi-cog"></i> Configure</button>
nautobot/dcim/templates/dcim/module_consoleports.html:                        <button type="button" class="btn btn-default btn-xs" data-toggle="modal" data-target="#ModuleConsolePortTable_config" title="Configure table"><i class="mdi mdi-cog"></i> Configure</button>
nautobot/dcim/templates/dcim/module_consoleserverports.html:                        <button type="button" class="btn btn-default btn-xs" data-toggle="modal" data-target="#ModuleConsoleServerPortTable_config" title="Configure table"><i class="mdi mdi-cog"></i> Configure</button>
nautobot/dcim/templates/dcim/module_frontports.html:                        <button type="button" class="btn btn-default btn-xs" data-toggle="modal" data-target="#ModuleFrontPortTable_config" title="Configure table"><i class="mdi mdi-cog"></i> Configure</button>
nautobot/dcim/templates/dcim/module_interfaces.html:                        <button type="button" class="btn btn-default btn-xs" data-toggle="modal" data-target="#ModuleInterfaceTable_config" title="Configure table"><i class="mdi mdi-cog"></i> Configure</button>
nautobot/dcim/templates/dcim/module_modulebays.html:                        <button type="button" class="btn btn-default btn-xs" data-toggle="modal" data-target="#ModuleModuleBayTable_config" title="Configure table"><i class="mdi mdi-cog"></i> Configure</button>
nautobot/dcim/templates/dcim/module_poweroutlets.html:                        <button type="button" class="btn btn-default btn-xs" data-toggle="modal" data-target="#ModulePowerOutletTable_config" title="Configure table"><i class="mdi mdi-cog"></i> Configure</button>
nautobot/dcim/templates/dcim/module_powerports.html:                        <button type="button" class="btn btn-default btn-xs" data-toggle="modal" data-target="#ModulePowerPortTable_config" title="Configure table"><i class="mdi mdi-cog"></i> Configure</button>
nautobot/dcim/templates/dcim/module_rearports.html:                        <button type="button" class="btn btn-default btn-xs" data-toggle="modal" data-target="#ModuleRearPortTable_config" title="Configure table"><i class="mdi mdi-cog"></i> Configure</button>