GitRepository URL Validator does not allow for local DNS URLs

MeganerdDev commented 2 weeks ago

Environment

Nautobot version (Docker tag too if applicable): v2.2.25
Python version: 3.11
Database platform, version: PG15
Middleware(s): N/A

Steps to Reproduce

Navigate to extras/git-repositories in the Nautobot UI
Press the Add button to begin creating a new GIT Repository object
On the Remote URL charfield entry provide a local DNS name eg: https://local-dns-example/golden-config-backup.git
Fill in remaining required entries and press Update & Sync button

Expected Behavior

Object created and syncs as normal operation

Observed Behavior

URL validator throws an error preventing creation of the object

Additional Details

I wasn't sure if this would be a feature request or a bug report. I ended up with bug report.
URLValidator is upstream and provided by Django from django.core.validators import URLValidator
URLValidator in Django

MeganerdDev commented 2 weeks ago

I was able to mitigate this over the ORM for now

from nautobot.extras.models import GitRepository

GitRepository.objects.create(
    name="test",
    slug="test",
    remote_url="https://local-dns-example/golden-config-backup.git",
    branch="main"
)

Also unrelated to the URL Validator for local DNS names, but local pathfiles might also be considered during any refactoring change that is done to this entry? I had a separate case where I worked around this by creating the object over ORM

glennmatthews commented 1 week ago

Nautobot has a custom nautobot.core.models.validators.EnhancedURLValidator that supports hostnames, it looks like it might just be as simple as fixing the GitRepository definition to use that instead of Django's default URLValidator.

glennmatthews commented 1 week ago

Similarly the form itself needs to use nautobot.core.forms.fields.LaxURLField instead of Django's forms.URLField.

nautobot / nautobot