search

nautobot / pynautobot

Nautobot Python SDK
https://pynautobot.readthedocs.io/en/latest/index.html
Apache License 2.0
34 stars 29 forks source link

Added a bulk delete method to the endpoint class #163

Closed tsm1th closed 5 months ago

tsm1th commented 5 months ago

This adds a delete method to the endpoint class and other changes to support bulk deletes. If accepted, then this should resolve #131

joewesch commented 5 months ago

Thanks for the PR @vu-smitt13. Can you look at adding some appropriate tests as well?

tsm1th commented 5 months ago

@joewesch Added unit tests and extended error handling.

joewesch commented 5 months ago

In the interests of coverage, let's add a couple tests to verify they raise the exception for invalid UUID/types. The rest of the code looks great, so no other changes needed from me otherwise.

tsm1th commented 5 months ago

@joewesch Added three new tests. I can make them less specific if needed.

joewesch commented 5 months ago

@vu-smitt13 it looks like you still have some failing CI tests if you can review and rectify those. Once CI passes I think we are good to merge.

tsm1th commented 5 months ago

@joewesch Passing now. I opened another issue last week for bulk updates. I needed both features so I can submit a PR for that as well if deemed beneficial.