nautobot / pynautobot

Nautobot Python SDK
https://pynautobot.readthedocs.io/en/latest/index.html
Apache License 2.0
38 stars 32 forks source link

WIP: Initial testing strategy for testing custom record __str__ methods #58

Closed FragmentedPacket closed 1 year ago

FragmentedPacket commented 2 years ago

I'll take the credit of finding (introducing) these bugs :P

But in reality, we just need to extend test coverage as much as we can within this library so it'll help us understand the underlying code for this library and help reduce regression bugs with changes implemented since the code has changed very little since the fork.

These tests that I'm writing are to mainly make sure that all endpoint records (custom and not) display the correct string and any custom attributes for child objects on records are the correct instances. This is an initial pattern for these tests that I want to get feedback on and make sure it makes sense before moving forward to writing the remaining tests for all endpoints.

FragmentedPacket commented 2 years ago

@glennmatthews I would love your feedback on this as well!

FragmentedPacket commented 2 years ago

I think I could potentially fold this into the generic tests actually. I will look into that as well.

jvanderaa commented 2 years ago

@FragmentedPacket thinking you want to tackle this one yet?

FragmentedPacket commented 2 years ago

I will prob have to have someone else take this over! Not sure if i'll have time in the near future to complete this.