nav-gov-hu / SAF-T_HU

Public repository of the SAF-T_HU project
Other
18 stars 19 forks source link

[DOC] Discrepency between file metadata hash algorithm #10

Open przerull opened 4 years ago

przerull commented 4 years ago

In the Definitions XSD file, the Metadata Sections ask for a SHA512 hash of the xml files.

However, on page 18 of the English translation in the documentation, it asks for an MD5.

Both hash functions will produce values which conform to the XSD's requirements, however given an xml file, the SHA512 algorighm will return a different result than the MD5 function.

This discrepancy is also matched in the XSD file itself:

https://github.com/nav-gov-hu/SAF-T_HU/blob/1a72d1ee91365babef2406af5c84c3d8c7561702/src/schemas/nav/gov/hu/SAF-T_HU/SAFT_HU_Definitions.xsd#L47-L52

The annotation in the original hungarian asks for the SHA512, whereas the English annotation requests the MD5.

It seems that the SHA512 should be preferred, but the English documentation should be updated to reflect this.

NTCA-tax commented 4 years ago

The English documentation will not be updated in the pilot phase. Thanks for the notification, the Hungarian annotation is the valid. We will correct the English annotation.