Copy Pocket operation + save duplicates operation, generates Sketch ID confusion

[GoogleCodeExporter]

What steps will reproduce the problem?

1. Add a sketch + select it
2. Add a Pocket operation
3. Select this Copy operation
4. Paste this into Operations
4a. Save the result -
We now have 2 pocket operations. 

5. Now save this, result in  pocket-copy-bug-save1.heeks
6. Quit the program, restart, and load this file.
7. You get *three* Pocket operations = Bug2. 
8. Save again, results in pocket-copy-bug-save2.heeks

What is the expected output? What do you see instead?

on steps 1-4 I would have expected either:
- the copied Pocket Operation just references the original sketch, in which 
case it had the same ID and manipulating it would change that sketch in both 
pockets
- if the 'Copy' does a deep copy (a full copy of the sketch, as it obviously 
does), then the copied sketch should have a new ID, and saved as such. However, 
it has the same id as the original sketch despite being a different object 
(also in .heeks file)

on steps 5-7 I would have expected 2 operations, not 3

done with Heekscad at r1359, + Heekscnc are at r 1245

Original issue reported on code.google.com by haberl...@gmail.com on 17 Nov 2010 at 1:12

Attachments:

• pocket-copy-bug-save1.heeks
• pocket-copy-bug-save2.heeks

[GoogleCodeExporter]

if I manually edit the first saved file and change the second Pocket's
ID to a unique new value, opening the file at least results in the
right number of pockets, with different id's.

However, the second Pocket still has two child pockets, which is wrong

If I manually edit the file again and change the second Pocket's child
sketch ID to another unique value, the import works right.

Which leads me to believe: Copy + Paste into should give Objects new ID's .

Original comment by haberl...@gmail.com on 17 Nov 2010 at 11:09

[GoogleCodeExporter]

I have noticed this bug as well. 

The software will also not generate a cutting path when you click G0 unless you 
alter the ID of the copied operation.

Original comment by williamr...@googlemail.com on 24 Nov 2010 at 5:28

[GoogleCodeExporter]

Could this bug be related to a save bug too?
If you import a stl, and make a scetch around it, then pocket the scetch and 
add a attachop to the stl, and move the attach to abowe the pocket you get 
atleast two stl's selected in your attachop.

If you do it the correct way and attachop before you do the pocket it sems fine 
untill you run processing, at which point the extra stl shows up.

Original comment by tha_krea...@hotmail.com on 20 Feb 2011 at 4:20

[GoogleCodeExporter]

This is fine in version 1.0

Original comment by danhe...@gmail.com on 24 Mar 2014 at 5:29

• Changed state: Fixed