search

navapbc / template-infra

A template to set up foundational infrastructure for your application in AWS
Apache License 2.0
9 stars 2 forks source link

Eliminate .sh extension from shell scripts #635

Closed daphnegold closed 2 weeks ago

daphnegold commented 3 weeks ago

Ticket

Resolves #620

Changes

Context for reviewers

google shell style guide

Regarding the Lint Markdown CI check failing, it is finding two dead links since I changed the file names. These should be resolved on merging. 

  ERROR: 1 dead links found!
  [✖] https://github.com/navapbc/template-infra/tree/main/template-only-bin/download-and-install-template → Status: 404

  ERROR: 1 dead links found!
  [✖] https://github.com/navapbc/template-infra/blob/main/template-only-bin/update-template#L17-L28 → Status: 404

Testing

platform-test branch successful deploy to platform-test platform-test PR

lorenyu commented 3 weeks ago

A few other small testing requests.

Can you try running the following commands in platform-test to make sure they still work

make infra-update-app-database-roles
make infra-check-app-database-roles
make infra-configure-app-service # should be a no-op

and put screenshots of those runs in the platform-test PR

lorenyu commented 3 weeks ago

the platform-test PR diff looks messed up. there are changes in there that aren't relevant, and there are also template only files that shouldn't be there. i suggest deleting that branch and starting over.

  1. in template-infra, merge main into this branch to bring this branch up to date with main
  2. in platform-test, pull all changes in main
  3. in platform-test, create a fresh branch from main
  4. copy over the changes from template-infra into platform-test, ignoring any file that has template-only in the path
daphnegold commented 2 weeks ago

the platform-test PR diff looks messed up. there are changes in there that aren't relevant, and there are also template only files that shouldn't be there. i suggest deleting that branch and starting over.

  1. in template-infra, merge main into this branch to bring this branch up to date with main
  2. in platform-test, pull all changes in main
  3. in platform-test, create a fresh branch from main
  4. copy over the changes from template-infra into platform-test, ignoring any file that has template-only in the path

I think we are good now. I didn't copy over the template-only files mindlessly this time.