search

navapbc / template-infra

A template to set up foundational infrastructure for your application in AWS
Apache License 2.0
9 stars 2 forks source link

Refine replace trigger for installation of role manager packages #648

Closed lorenyu closed 2 weeks ago

lorenyu commented 2 weeks ago

Ticket

N/A

Changes

see title

Context for reviewers

Previously we only ran installation of role manager packages when the requirements.txt file changed, but this means that new infra engineers who ran terraform apply without having the packages installed locally would update the terraform lambda function to a zip file that didn't contain the dependencies, breaking the role manager.

In this PR https://github.com/navapbc/template-infra/pull/452/files we changed the package installation to always install, which fixed the issue but created an annoying situation where the terraform plan would always show changes to apply.

This change introduces a hybrid solution that works around the new engineer issue by triggering an installation of role manager packages locally if the zip archive doesn't exist locally. Otherwise it relies on changes to requirements.txt. It's not a perfect solution in that terraform apply needs to be run twice in order to get it into a stable state where the replacement trigger is set to the contents of requirements.txt, but it's an improvement over the previous two solutions.

Testing

Developed and tested on platform-test PR https://github.com/navapbc/platform-test/pull/107

lorenyu commented 2 weeks ago

Rollout note: I finished applying the changes to platform-test and platform-test-flask so those should have clean plans on main branch now