search

navapbc / template-infra

A template to set up foundational infrastructure for your application in AWS
Apache License 2.0
9 stars 2 forks source link

Default has_database to true #652

Closed lorenyu closed 2 weeks ago

lorenyu commented 2 weeks ago

Ticket

n/a

Changes

see title

Context for reviewers

Default has_database to true based on feedback from project teams. Most projects need a database anyways so it's by far the common case.

Testing

This only changes the default config for a project, not any project specific functionality, so no specific testing is done. Template only CI should still pass, needed to revert has_database to false in template only CI since we don't want to spin up the database for template only CI.

Rollout notes

  1. Template CD will incorrectly set has_database to true in platform-test-nextjs, we'll need to revert that
  2. Template CD will probably fail for platform-test and platform-test-flask since this line is already changed in those projects. We'll need to just update the .template-version file manually
rocketnova commented 2 weeks ago

@lorenyu I think this is a dupe of #485. We had some unresolved comments on that PR, like this one https://github.com/navapbc/template-infra/pull/485#discussion_r1412476886

lorenyu commented 2 weeks ago

@rocketnova totally forgot about that PR apologies! closing this in favor of that one