Rename internal shell variables to be lower case (template-only-bin)

navapbc / template-infra

A template to set up foundational infrastructure for your application in AWS

Apache License 2.0

9 stars 2 forks source link

Rename internal shell variables to be lower case (template-only-bin) #660

Closed daphnegold closed 1 week ago

daphnegold commented 1 week ago

Ticket

Resolves #638

Changes

Correct local variables to be lowercase per convention

Context for reviewers

This is a continuation of ticket #532

Testing

The CI Infra Tests that use the template-only-bin scripts are working fine

daphnegold commented 1 week ago

optional, we're moving to using "${var}" syntax instead of "$var", so if you're up for it you can also rename some of the variable references in install-template, set-up-project, and update-template where i still see variable references like "$var"

Small change I'm happy to do, but maybe in a follow up PR since this one is ready to go? Thank you for the suggestion.