navapbc / template-infra

A template to set up foundational infrastructure for your application in AWS
Apache License 2.0
9 stars 2 forks source link

Change references to ${var} from $var in scripts #663

Closed daphnegold closed 5 days ago

daphnegold commented 1 week ago

Ticket

Resolves #661

Changes

Testing

Platform Test PR Platform Test Deploy

daphnegold commented 1 week ago

Looks great! Thanks so much for tackling this. Much much appreciated.

Can you run just a couple of more tests? In the platform-test repo, in your branch, can you test out the following commands:

  1. make infra-set-up-current-account (check to see that it succeeded and no files changed)

  2. make infra-update-app-database-roles APP_NAME=app ENVIRONMENT=dev

  3. make infra-check-app-database-roles APP_NAME=app ENVIRONMENT=dev

  1. and 3. already have screenshots in the platform-test PR. I ran account setup iirc, I'll add screenshot for that when I'm back at my computer.