search

navapbc / template-infra

A template to set up foundational infrastructure for your application in AWS
Apache License 2.0
9 stars 2 forks source link

Remove no longer needed manual deletion in CI Infra Service Checks #668

Closed rocketnova closed 1 week ago

rocketnova commented 1 week ago

Ticket

N/A

Changes

What was added, updated, or removed in this PR.

  • Updates CI test called in "CI Infra Service Checks"

Context for reviewers

Testing instructions, background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers.

Now that #649 has been merged, the infra_test.go service layer test no longer needs to run a separate terraform apply to remove deletion protection on service resources. Since the CI job runs in a terraform workspace, the resources are no longer deployed with deletion protection.

This PR removes the no longer needed code in the test.

Testing

Provide evidence that the code works as expected. Explain what was done for testing and the results of the test plan. Include screenshots, GIF demos, shell commands or output to help show the changes working as expected. ProTip: you can drag and drop or paste images into this textbox.

Tested on https://github.com/navapbc/platform-test/pull/116 with a link to the passing test.