⚠️ Move account_name from app config to network config - Githubissues

navapbc / template-infra

A template to set up foundational infrastructure for your application in AWS

Apache License 2.0

9 stars 2 forks source link

⚠️ Move account_name from app config to network config #673

Closed lorenyu closed 1 week ago

lorenyu commented 1 week ago

Ticket

Resolves https://github.com/navapbc/template-infra/issues/670

Changes

Add account_name to network configs
Remove account_name from environment configs
Remove account_names_by_environment from app-config
Add ability for configure-aws-credentials custom action to log in by account_name and network_name

Context for reviewers

See ticket. Also, this is a prerequisite for #117

⚠️ Migration notes

Remove account_name from each environment config file <ENVIRONMENT>.tf in the infra/<APP_NAME>/app-config/ folder
Add account_name to each network config in infra/project-config/networks.tf

Testing

Developed and tested in platform-test in https://github.com/navapbc/platform-test/pull/119

lorenyu commented 1 week ago

sorry requested reivew too soon, need to do more testing

lorenyu commented 1 week ago

Added a migration notes section to the PR description that we can include when we create release notes