navapbc / wic-participant-recertification-portal

https://navapbc.github.io/wic-participant-recertification-portal/

Apache License 2.0

0 stars 1 forks source link

[PRP-352] Separate s3 bucket for application vs logging #115

Closed rocketnova closed 1 year ago

rocketnova commented 1 year ago

Ticket

https://wicmtdp.atlassian.net/browse/PRP-352

Changes

What was added, updated, or removed in this PR.

Creates a separate terraform child module for making an s3 bucket for logging other AWS resources
Creates one s3 bucket for logging to s3 for each environment, rather than one bucket for each resource in each environment
Remove extra s3 bucket created for WAF logging because WAF is logging to cloudwatch

Context for reviewers

Testing instructions, background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers. Explain how the changes were verified.

103 added logging but the s3 bucket logging wasn't quite right. Corrected here.

Testing

Screenshots, GIF demos, code examples or output to help show the changes working as expected. ProTip: you can drag and drop or paste images into this textbox.

These changes have been deployed to dev and can be verified there.