Closed rocketnova closed 1 year ago
Sure is! If it doesn't apply, ignore it and I'll approve 🙃
On Mon, Mar 13, 2023, at 11:09 AM, Rocket wrote:
@.**** commented on this pull request.
In infra/modules/iam/main.tf https://github.com/navapbc/wic-participant-recertification-portal/pull/14#discussion_r1134430772:
- "kms:DescribeKey", "kms:CreateAlias", "kms:Decrypt",
Good question! I'm not sure. I know these permissions allow a user (one of us) in the user group to create and destroy environments, including the S3 buckets.
Do we need to put files into the S3 bucket? Is this in reference to how we're going to handle doc upload?
— Reply to this email directly, view it on GitHub https://github.com/navapbc/wic-participant-recertification-portal/pull/14#discussion_r1134430772, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFQTP7SID7AKGPAX7WMXFLW35PHHANCNFSM6AAAAAAVS7N34E. You are receiving this because your review was requested.Message ID: @.***>
Sure is! If it doesn't apply, ignore it and I'll approve 🙃
@microwavenby Yah, this PR doesn't cover anything to do with doc upload, so it's a good concern for @aplybeah's upcoming PR on doc upload
Ticket
Changes
us-west-1
tous-west-2
infra/accounts/account/
moduleinfra/modules/database
moduleinfra/modules/random_password
moduleinfra/modules/service_cluster
modulewic-prp-eng
user groupapi
Context for reviewers
This PR started out as just migrating our resources from
us-west-1
tous-west-2
, but as we deleted all the resources and re-created them, it didn't make sense to re-create them in the wrong pattern when we knew we were about to need them to be different.So, in addition to the region change, we also modified the env-template to support our current project architecture (1 database, 1 service cluster, 3 services). To do this, we broke out some of the resources that were previously grouped into the service module into their own separate modules. We renamed our resources to ensure that each environment had its own dedicated resources.
Testing
These changes have all been deployed to our AWS account. To confirm that all of the resources exist and are configured properly. Please check all of the following against the terraform files.
build-repository
cluster:
database
service