navapbc / wic-participant-recertification-portal

https://navapbc.github.io/wic-participant-recertification-portal/
Apache License 2.0
0 stars 1 forks source link

[PRP-168 to PRP-170] Set up CI/CD for staff portal #35

Closed rocketnova closed 1 year ago

rocketnova commented 1 year ago

Ticket

Changes

What was added, updated, or removed in this PR.

Context for reviewers

Testing instructions, background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers. Explain how the changes were verified.

Testing

Screenshots, GIF demos, code examples or output to help show the changes working as expected. ProTip: you can drag and drop or paste images into this textbox.

github-advanced-security[bot] commented 1 year ago

You have successfully added a new CodeQL configuration /language:javascript. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

rocketnova commented 1 year ago

I'm sure you're aware, but this PR isn't a merge to main?

Yeah. When I do work like this, if possible, I try to control the order in which I do the merging so that I can:

  1. make the PR atomic so that reviewers can more easily see the differences
  2. then when the base branch gets merged into main, Github automatically changes the base branch to main
  3. then merge the follow on work