navapbc / wic-participant-recertification-portal

https://navapbc.github.io/wic-participant-recertification-portal/
Apache License 2.0
0 stars 1 forks source link

[PRP-253] Fixes from live UAT on 2023-03-22 #39

Closed rocketnova closed 1 year ago

rocketnova commented 1 year ago

Ticket

https://wicmtdp.atlassian.net/browse/PRP-253

Changes

What was added, updated, or removed in this PR.

Context for reviewers

Testing instructions, background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers. Explain how the changes were verified.

These changes came out of our Live UAT session on 2023-03-22.

Testing

Screenshots, GIF demos, code examples or output to help show the changes working as expected. ProTip: you can drag and drop or paste images into this textbox.

Review the chromatic storybook

makaelastephens commented 1 year ago
Screen Shot 2023-03-28 at 1 18 03 PM

The spacing between the DOB field and "Are they enrolled in these other programs"? is very tight.

Screen Shot 2023-03-28 at 1 18 39 PM

Can we overwrite the line length for "How many people..." so it's similar to measure-6?

rocketnova commented 1 year ago

@makaelastephens

Screen Shot 2023-03-28 at 1 18 03 PM

The spacing between the DOB field and "Are they enrolled in these other programs"? is very tight.

🤔 I'll take a look at that.

Screen Shot 2023-03-28 at 1 18 39 PM

Can we overwrite the line length for "How many people..." so it's similar to measure-6?

This is the USWDS standard form label max-width. Do you want to change it across the board?

Screen Shot 2023-03-28 at 11 14 42 AM

makaelastephens commented 1 year ago

@rocketnova

This is the USWDS standard form label max-width. Do you want to change it across the board?

Yes, we want to change it across the board. Checking the galaxy brain notes, unfortunately we didn't write down what we wanted the override to be so let me know if you need more eyes later.

rocketnova commented 1 year ago

@makaelastephens

Screen Shot 2023-03-28 at 1 18 03 PM

The spacing between the DOB field and "Are they enrolled in these other programs"? is very tight.

🤔 I'll take a look at that.

@makaelastephens Turns out this is a known USWDS bug when you use legends without labels in fieldsets 😞 I'll do some custom CSS'ing to fix. Also fun: this affects chrome but not firefox

github-actions[bot] commented 1 year ago

Chromatic_Build : Link to latest build in Chromatic 🌈 Link to storybook build in Chromatic

danielladevera-nava commented 1 year ago

The changes noted in the comments above now look as expected to me 👍.