Closed rocketnova closed 1 year ago
The spacing between the DOB field and "Are they enrolled in these other programs"? is very tight.
Can we overwrite the line length for "How many people..." so it's similar to measure-6?
@makaelastephens
The spacing between the DOB field and "Are they enrolled in these other programs"? is very tight.
🤔 I'll take a look at that.
Can we overwrite the line length for "How many people..." so it's similar to measure-6?
This is the USWDS standard form label max-width. Do you want to change it across the board?
@rocketnova
This is the USWDS standard form label max-width. Do you want to change it across the board?
Yes, we want to change it across the board. Checking the galaxy brain notes, unfortunately we didn't write down what we wanted the override to be so let me know if you need more eyes later.
@makaelastephens
The spacing between the DOB field and "Are they enrolled in these other programs"? is very tight.
🤔 I'll take a look at that.
@makaelastephens Turns out this is a known USWDS bug when you use legends without labels in fieldsets 😞 I'll do some custom CSS'ing to fix. Also fun: this affects chrome but not firefox
Chromatic_Build : Link to latest build in Chromatic 🌈 Link to storybook build in Chromatic
The changes noted in the comments above now look as expected to me 👍.
Ticket
https://wicmtdp.atlassian.net/browse/PRP-253
Changes
t()
to<Trans>
where possible to support basic html tags in i18n strings<em>
tags in i18n strings<div>
tags around paragraph content to<p>
tagsen/common.json
.intro
class for intro paragraphs on pages.legend-large
and.label-large
class for our large labels/legends<List>
component<AdjunctiveInput>
,<DateInput>
, and<RelationshipInput>
components as required fieldsclassName
argument<RequiredQuestionStatement>
to all pages with required fieldstype=number
, set max width on the input field, use the.label-large
classContext for reviewers
These changes came out of our Live UAT session on 2023-03-22.
Testing
Review the chromatic storybook