navapbc / wic-participant-recertification-portal

https://navapbc.github.io/wic-participant-recertification-portal/
Apache License 2.0
0 stars 1 forks source link

PRP-221 Completing the /upload page #58

Closed microwavenby closed 1 year ago

microwavenby commented 1 year ago

Ticket

https://wicmtdp.atlassian.net/browse/PRP-221

Changes

Testing

Screenshots, GIF demos, code examples or output to help show the changes working as expected. ProTip: you can drag and drop or paste images into this textbox. upload-page-demo

makaelastephens commented 1 year ago

Design feedback:

microwavenby commented 1 year ago

Yes, that's correct We'd pass the creds in as secrets through the container task definition

On Wed, Apr 19, 2023, at 3:24 PM, Rocket wrote:

@.**** commented on this pull request.

In participant/.env.example https://github.com/navapbc/wic-participant-recertification-portal/pull/58#discussion_r1171908389:

+AWS_ACCESS_KEY_ID=e2e_minio +AWS_SECRET_ACCESS_KEY=incredible_local_secret_phrase

It looks like we will need to provision a IAM user with permissions to access the S3 bucket. Is that correct?

If so, I have tf WIP for that saved for that that I'll use in a new ticket https://wicmtdp.atlassian.net/browse/PRP-278 I've created for making sure we get all the correct env vars to the participant ECS task

— Reply to this email directly, view it on GitHub https://github.com/navapbc/wic-participant-recertification-portal/pull/58#pullrequestreview-1392962447, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFQTP2DXOEQP7T3PKHHTA3XCBQZLANCNFSM6AAAAAAXDMGLRQ. You are receiving this because you were assigned.Message ID: @.***>

github-actions[bot] commented 1 year ago

Chromatic_Build : Link to latest build in Chromatic 🌈 Link to storybook build in Chromatic