Bug: Missing GitSign background

captainko commented 2 years ago

I think we are missing background-color. I could create PR for this but I don't know how to do it properly.

xeluxee commented 2 years ago

@captainko can you share your onedark setup?

Are you experiencing the same issue with LSP diagnostics signs, such as error and warning signs?

captainko commented 2 years ago

@captainko can you share your onedark setup?

Here is my highlights

vim.api.nvim_exec([[
colorscheme onedark
hi! Normal guibg=none
hi! NonText guibg=none
hi! EndOfBuffer guibg=none
hi! EndOfBuffer guibg=none
hi! DiagnosticVirtualTextError guibg=none
hi! DiagnosticVirtualTextWarn guibg=none
hi! DiagnosticVirtualTextInfo guibg=none
hi! DiagnosticVirtualTextHint guibg=none
hi! GruvFloatNormal ctermfg=223 ctermbg=235 guibg=#282828
hi! link helpCommand helpNormal
hi! link helpExample helpConstant
hi! link CursorLineNr TSConstant
]], false)

Are you experiencing the same issue with LSP diagnostics signs, such as error and warning signs?

Yeah, all of them are missing the background.

captainko commented 2 years ago

Ok I see I'm doing it wrong. I have to set the transparent in the setup method.

xeluxee commented 2 years ago

@captainko take a look at how to customize colors and highlights, so you don't have to use nvim_exec

Also please notice that instead of hi! DiagnosticVirtualTextError guibg=none you can disable diagnostics virtual text background with

require('onedark').setup {
    diagnostics = {
        background = false,    -- background color for virtual text
    },
}

For futher customization give a look at configuration

navarasu / onedark.nvim

Bug: Missing GitSign background #55