search

navarasu / onedark.nvim

One dark and light colorscheme for neovim >= 0.5.0 written in lua based on Atom's One Dark and Light theme. Additionally, it comes with 5 color variant styles
MIT License
1.54k stars 155 forks source link

Provide a theme for vim-airline? #6

Open moshiur-raj opened 3 years ago

moshiur-raj commented 3 years ago

onedark.nvim does not provide any theme for vim-airline. Switching to this theme makes airline stick to the default themes and it looks ugly.

navarasu commented 3 years ago

Sure. I will add it.

moshiur-raj commented 3 years ago

Thank you.

navarasu commented 3 years ago

@moshiur-raj Instead of vim-airline. I thought to support lua only status plugins like hardline, bufferline. Your Thoughts?

moshiur-raj commented 3 years ago

@navarasu Sounds reasonable to me. I actually was able to fix the problem with airline. airline provides extra themes with vim-airline-themes. So you don't need to maintain it. I recently switched to lualine.

baco commented 3 years ago

@moshiur-raj Instead of vim-airline. I thought to support lua only status plugins like hardline, bufferline. Your Thoughts?

@navarasu perhaps also that, but don't refrain from supporting vim-airlaine. Vim-airline is a widely used plugin, and offers functionality that goes beyond the chosen colorscheme. Many of us have lots of plugins already configured for airline, and having to redo that work for that plugin, just only for the theme, doesn't worth it.

moshiur-raj commented 3 years ago

@baco vim-airline already provides a onedark theme. It's available here.

baco commented 3 years ago

@moshiur-raj fair enough. Never installed it, because @joshdick's onedark.vim came with it's own implementation for Airline

joshdick commented 3 years ago

FWIW, I added the onedark airline theme into vim-airline-themes (in turn based on the one that ships with my own joshdick/onedark.vim) back in 2017, but I haven’t kept changes between those two versions synced.

baco commented 3 years ago

FWIW, I added the onedark airline theme into vim-airline-themes back in 2017, but I haven’t kept changes between those two versions synced.

Will you PR an update there, please?

navarasu commented 3 years ago

@baco As I support 5 more color variants, adding a theme to vim-airline-themes will not be good. So I will add airline support in this plugin itself by supporting all color variants. I think it is fine to support few vim plugins until the Lua plugins get mature.

baco commented 3 years ago

Thak you @navarasu, that's excellent news!

schardev commented 2 years ago

Any further update on this? @navarasu