Constant DEFAULT_PORT insted of hard coding "7"

navarr / Sockets

PHP Socket Classes

MIT License

50 stars 23 forks source link

Constant DEFAULT_PORT insted of hard coding "7" #12

Closed christoffer-ekblom closed 8 years ago

navarr commented 8 years ago

Thanks for your request! You're right, even if it's a demo it should use best practices, which would mean separating out the magic number into a constant.

Needs one quick change to properly scope the constant and it'll be ready to merge!

navarr commented 8 years ago

Changes present in ab06654. Thank you for your PR.