Closed tsejerome closed 2 years ago
crashes on both iOS device and simulator when trying to send email or copying to clipboard
if an exception happens while the blurry modal is shown, then the toast is not visible:
if an exception happens while the blurry modal is shown, then the toast is not visible:
fixed in https://github.com/navcoin/WhisperWallet/pull/104/commits/1db374948ab10f9f573c91b3a90fb4fea6e9c047
the toast text is not readable tapping the toast does nothing the toast does not stay visible long enough
what happens if I miss the toast? it should be possible to access the exceptions log from somewhere (maybe settings?)
also, the text says something was wrong in the previous session, but this exception just occurred now.
more comments:
more comments:
- the toast does not seem to have the background colour we commented on telegram (aligned with the app ui)
- I think, cosmetically, it would benefit from a bit more of space on top of the toast
those and these:
also, the text says something was wrong in the previous session, but this exception just occurred now.
are fixed with https://github.com/navcoin/WhisperWallet/pull/104/commits/13774a7a062e35a054944f713ac8a0470a1c5d1f and https://github.com/navcoin/WhisperWallet/pull/104/commits/5a1f9c36d5fada698c963b1eaf580a1d83631902
Ready for review again, note that the last part of the video is not up to date, I fixed the issue where the error was wrongly copied
everytime I restart the app on this branch I am shown the onboarding screen and asked if I want to lock the screen. seems like something related to AsyncStorage
Just resolved the issue you mentioned! its about RNBootsplash.hide and the setLoaded in App.tsx
@aguycalled I just resolved some merge conflict for this branch, please review and see if there is any issues (if not please kindly merge)
merge looks good, tested on simulator
Resolves #56