navcoin / WhisperWallet

Whisper Wallet
5 stars 4 forks source link

Not asking for pin when deleting wallet #112

Closed chasingkirkjufell closed 2 years ago

chasingkirkjufell commented 2 years ago

When clicking on deleting the wallet, users should be asked to confirm and then re-enter the pin. I didn't check the biometric lock, but in the biometric case, user should be ask to confirm the action first and then check for biometric to avoid accident clicks and conformation.

aguycalled commented 2 years ago

I think it should also ask for explicit confirmation:

The coins stored on the wallet will be lost and only accessible again using a valid backup. Please be sure your seed words are correctly backed up.

Are you sure you want to delete this wallet?
aguycalled commented 2 years ago

fixed in 6ee4962