navcoin / WhisperWallet

Whisper Wallet
5 stars 4 forks source link

Private NFT: Explore collection #151

Closed aguycalled closed 2 years ago

aguycalled commented 2 years ago

This task consists on finishing the CollectionScreen screen in the branch private-nfts

This screen receives a parameter collection from MainWallet.

This object stores the items from the collection owned by the wallet:

collection = {
  items: {
    confirmed: {},
    pending: {}
  }
}

confirmed and pending are dictionaries where the key is the nft id and the value is the metadata of the nft.

Tasks:

Considerations

tsejerome commented 2 years ago

Normal View

image image

Pending Art

image

image

aguycalled commented 2 years ago

I think items need some padding (both expanded and in collection view)

tsejerome commented 2 years ago

wdym padding in collection view, referenced from instagram there is no padding on the left and right, only between items. Do you want more padding between items?

For expanded view, I checked major app like facebook and instagram, they did full view so they didn't have any padding around the images.

tsejerome commented 2 years ago

Updates: working on IPFS integration.. IPFS is not fully ready for react-native and it leads to an issue as attached. There are current polyfills for fixing it and it will take time to experiment it. References: https://github.com/ipfs/js-ipfs/issues/3404 image

aguycalled commented 2 years ago

maybe a border for each item (like instagram has), can help to differentiate between them in a collection. for the expanded view, what about adding a bg color to the item? to cover cases where the image background is transparent