search

navcoin / navcoin-core

bitcoin-core 0.13 fork ported for NavCoin
MIT License
123 stars 92 forks source link

Staking report broken on 4.6.0 RC when using a cold stake wallet #445

Closed mxaddict closed 5 years ago

mxaddict commented 5 years ago

I have a cold staking wallet.

And staking report is wrong when using 4.6.0 RC

{
  "2019-04-26 16:00:00": "0.00",
  "2019-04-25 16:00:00": "-8833.93873429",
  "2019-04-24 16:00:00": "-16719.44565578",
  "2019-04-23 16:00:00": "0.00",
  "2019-04-22 16:00:00": "2.00",
  "2019-04-21 16:00:00": "2.00",
  "2019-04-20 16:00:00": "2.00",
  "2019-04-19 16:00:00": "4.00",
  "2019-04-18 16:00:00": "2.00",
  "2019-04-17 16:00:00": "2.00",
  "2019-04-16 16:00:00": "4.00",
  "2019-04-15 16:00:00": "4.00",
  "2019-04-14 16:00:00": "4.00",
  "2019-04-13 16:00:00": "6.00",
  "2019-04-12 16:00:00": "4.00",
  "2019-04-11 16:00:00": "2.00",
  "2019-04-10 16:00:00": "2.00",
  "2019-04-09 16:00:00": "2.00",
  "2019-04-08 16:00:00": "6.00",
  "2019-04-07 16:00:00": "0.00",
  "2019-04-06 16:00:00": "0.00",
  "2019-04-05 16:00:00": "0.00",
  "2019-04-04 16:00:00": "6.00",
  "2019-04-03 16:00:00": "0.00",
  "2019-04-02 16:00:00": "0.00",
  "2019-04-01 16:00:00": "2.00",
  "2019-03-31 16:00:00": "2.00",
  "2019-03-30 16:00:00": "0.00",
  "2019-03-29 16:00:00": "0.00",
  "2019-03-28 16:00:00": "4.00",
  "Last 24H": "-8833.93873429",
  "Last 7 Days": "-25543.38439007",
  "Last 30 Days": "-25487.38426307",
  "Last 365 Days": "-25202.22851166",
  "Last All": "-25193.35322832",
  "Latest Stake": "-6046.0209064",
  "Latest Time": "2019-04-26 11:57:36",
  "Stake counted": 239,
  "time took (ms)": 1
}
aguycalled commented 5 years ago

does that wallet have the staking key, the spending key or both of them?

mxaddict commented 5 years ago

Only the cold wallet

On Sat, Apr 27, 2019, 04:50 alex v. notifications@github.com wrote:

does that wallet have the staking key, the spending key or both of them?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/NAVCoin/navcoin-core/issues/445#issuecomment-487197181, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIDAKMGP3O6LNRFF3WTK23PSNTJZANCNFSM4HIXAJ4A .

aguycalled commented 5 years ago

Does that mean spending or staking?

Von meinem iPhone gesendet

Am 27.04.2019 um 02:46 schrieb Barry Deeney notifications@github.com:

Only the cold wallet

On Sat, Apr 27, 2019, 04:50 alex v. notifications@github.com wrote:

does that wallet have the staking key, the spending key or both of them?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/NAVCoin/navcoin-core/issues/445#issuecomment-487197181, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIDAKMGP3O6LNRFF3WTK23PSNTJZANCNFSM4HIXAJ4A .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

mxaddict commented 5 years ago

@aguycalled, I checked the latest version on master branch (Compile and tested)

This is fixed on master, I guess it was fixed with #447 as well.

mxaddict commented 5 years ago

Does that mean spending or staking? Von meinem iPhone gesendet … Am 27.04.2019 um 02:46 schrieb Barry Deeney @.>: Only the cold wallet On Sat, Apr 27, 2019, 04:50 alex v. @.> wrote: > does that wallet have the staking key, the spending key or both of them? > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#445 (comment)>, > or mute the thread > https://github.com/notifications/unsubscribe-auth/AAIDAKMGP3O6LNRFF3WTK23PSNTJZANCNFSM4HIXAJ4A > . > — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

Sorry, I ment "staking" address/wallet

mxaddict commented 5 years ago

I noticed on master branch this is fixed, but...

But on a wallet.dat with only a "stake" address, the report justs says 0.00 Is this by design?

The issue was about it showing negative values.

In the current master branch, it's showing 0.00 which is technically correct, since the stakes are for the spending address, but it would be neat to see the stake report in the stake only wallet as well (I mean convenient)

Cause the way it is now, though technically it's correct to say 0.00, is inconvenient.

Cause to see the proper stake report, you will have to open the spending wallet

mxaddict commented 5 years ago

Ok, this issue and #446 seem to be closely related, so I will continue all discussion on #446

mxaddict commented 5 years ago

@aguycalled NRXfZ1egFxMSUsc4Ufpi4Lm7DdXStYmeBG

aguycalled commented 5 years ago

Paid e6fc101023a5212267fc7409f412ee83770af7b27ec548469d99db5c60c2bc06