DAO protocol upgrade

[aguycalled]

This PR proposes changes in the DAO voting system signalled by version bit 11.

Super Proposals

Super Proposals do not take coins out of the Community Fund but print them new.

Super Proposals can be created through the GUI or using the createproposal RPC command by setting to true the super parameter.

They are signalled in the RPC commands with super_proposal set to true.

Requirement for approval is 75% quorum and 90% acceptance.

What to test

• Super Proposals only work when the deployment is active.
• Super Proposals are only approved with the specified requirements.
• Super Proposals do not depend on the amount available on the Community Fund.
• Approval, rejection, expiration, block reorganisation do not affect the amount available in the Community Fund.
• Both RPC and GUI functionality work correctly.

Combined voting of consensus parameters

Not implemented in GUI yet, only in RPC commands.

A combined vote for change of consensus parameters can be started using the RPC command proposecombinedconsensuschange.

Example:

proposecombinedconsensuschange '[1, 2]' '[100, 100]'

Additional values can be proposed with proposeanswer:

proposeanswer f54c67f64fa1be51f23d9739d1f6b6a8e10d73f81ea8b7438445b3e52371ba43 '[150, 100]'

What to test

• Combined votes only work when the deployment is active.
• Combined votes can't be created when at least one of the indicated consensus parameters already has a voting active.
• Voting for those consensus change proposals work correctly.
• Proposed answers can't be duplicated.
• Proposed answers can't be the current value of the consensus parameters.
• RPC functionality work correctly.
• Please add as a comment to the Pull Request which parts of the GUI would need to be adapted to allow interaction with this new kind of votes.

[chasingkirkjufell]

i'd try to add this to the stressor and run it

[mxaddict]

@aguycalled seems this PR has a few conflicts with latest master

[aguycalled]

@aguycalled seems this PR has a few conflicts with latest master

fixed

[aguycalled]

i'd try to add this to the stressor and run it

would you like to add it yourself or should I add it?

[chasingkirkjufell]

i'd try to add this to the stressor and run it

would you like to add it yourself or should I add it?

I'd like to add it myself unless you're in a rush since I won't be able to get to it until later this week.

[chasingkirkjufell]

local build error

[chasingkirkjufell]

[mxaddict]

@aguycalled did gitian build the latest commit for this PR?

[mxaddict]

@aguycalled is there a command to check the current cfund balance via RPC?

[mxaddict]

@aguycalled is this message correct?

[mxaddict]

@aguycalled I was able to create a super proposal via GUI without the deployment being approved, but the network was waiting for cfund to have the balance, so just a GUI bug I assume, network accepted the proposal as a regular proposal.

[mxaddict]

My deployment gets stuck on "started" status even after several thousand blocks voted NO

[mxaddict]

Tested a super proposal with more amount requested than balance from cfund, worked nicely, was able to pass the proposal and create a payment request and receive the requested amount (GENERATED from AIR)

[mxaddict]

Tested super proposal via cli, worked as well, generated fresh coins and was able to request a payment, cfundstats was unfaffected throughout the process.

[mxaddict]

This PR is looking good, I guess once the GUI bug is fixed (able to created super proposal even when the deployment was not approved) this PR should be good.

@chasingkirkjufell how did you get the node to crash with this branch? I remember you mentioned a crashed node when using this branches build.

[chasingkirkjufell]

@mxaddict i updated my stress script and crashed the nodes. i provided the bt to aguycalled and it seems to be fixed so far. i'm still updating the script to test the combined consensus.

[mxaddict]

Nice

On Thu, Oct 28, 2021, 01:06 chasingkirkjufell @.***> wrote:

@mxaddict https://github.com/mxaddict i updated my stress script and crashed the nodes. i provided the bt to aguycalled and it seems to be fixed so far. i'm still updating the script to test the combined consensus.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/navcoin/navcoin-core/pull/856#issuecomment-953129341, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIDAKNPGGIRIPWFQU37UETUJAWSLANCNFSM5F5PPPLA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[navbuilder]

A new build of 756ef59e1cfacbea8be48e4bf6dcc8d405bfad56 has completed succesfully! Binaries available at https://build.nav.community/binaries/super-dao

[navbuilder]

A new build of a91aa2367d6ee07cdd33773a22a3e02a9dbe4ee8 has completed succesfully! Binaries available at https://build.nav.community/binaries/super-dao

[navbuilder]

A new build of 32308f84f706b0ea86f6c88b0894e64dc4247b71 has completed succesfully! Binaries available at https://build.nav.community/binaries/super-dao

[navbuilder]

A new build of e7c0d04500aa16716a4d65d173f451aa3d69943a has completed succesfully! Binaries available at https://build.nav.community/binaries/super-dao

[navbuilder]

A new build of 913711353a08ed60ea3ad2f1d21a93ea908b3c68 has completed succesfully! Binaries available at https://build.nav.community/binaries/super-dao

[navbuilder]

A new build of f9bcb64780568936ed09e88bec75eacc30288313 has completed succesfully! Binaries available at https://build.nav.community/binaries/super-dao

[navbuilder]

A new build of 5c6d837ff87ac69ae93260f3de1d5e4ccd554732 has completed succesfully! Binaries available at https://build.nav.community/binaries/super-dao

[navbuilder]

A new build of 50009f3da3861b23f4ba6a04e2165883c9e9d1c4 has completed succesfully! Binaries available at https://build.nav.community/binaries/super-dao

[mxaddict]

@aguycalled I'm doing final testing on this PR, once done will approve and merge, I think the GUI for the combined voting should be a seperate PR.

[navbuilder]

A new build of 87a95c610a38630479fb040293d1634a4d081976 has completed succesfully! Binaries available at https://build.nav.community/binaries/super-dao