navcoin / navcoin-core

bitcoin-core 0.13 fork ported for NavCoin
MIT License
123 stars 92 forks source link

Updated libgmp package in depends to work with WSL builds on windows #894

Closed mxaddict closed 2 years ago

mxaddict commented 2 years ago

Requires #891 NOTE: Just need to make sure that gitian build on Ubuntu/Gitian still work with this change

mxaddict commented 2 years ago

Closing this as I think I found a less intrusive method of getting WSL to work

mxaddict commented 2 years ago

This fix was only working for linux and osx builds, mingw32 was failing still

PATH=$(echo "$PATH" | sed -e 's/:\/mnt.*//g') # strip out problematic Windows %PATH% imported var

Re-opening as the fix for removing the WSL path values only works for osx and linux build on WSL, ironically windows builds on WSL were still failing.

mxaddict commented 2 years ago

Just did a WSL build for mingw32 and ran the navcoin-qt.exe from WSL CLI and worked good: image

mxaddict commented 2 years ago

Waiting on gitian build to see if this breaks anything in the build process.

navbuilder commented 2 years ago

A new build of 28dea21a3c464508d958785f81c5fca0745fe502 has completed succesfully! Binaries available at https://build.nav.community/binaries/fix-libgmp-depends-for-wsl