Add resolvename subdomains

[mxaddict]

closes #911

[navbuilder]

A new build of 302395cddda7c941e22bef6ce7201a5a9b1d61ad has completed succesfully! Binaries available at https://build.nav.community/binaries/add-resolvename-subdomains

[mxaddict]

I would say to include a check so If the client tries to resolve a name with subdomain like subdomain.name.nav, the resolve subdomain option can't be specified

Alright, I'll add it now, should it not allow it? Or just ignore the second param?

[aguycalled]

maybe it's enough just ignoring it

[chasingkirkjufell]

i thought that each dotnav can only have one subdomain? so there wouldn't be subdomains

[navbuilder]

A new build of b8b7ff3fb6d8f16424988abe42604cd8ca5ee9a9 has completed succesfully! Binaries available at https://build.nav.community/binaries/add-resolvename-subdomains

[mxaddict]

Yes, that is why we needed to add the check logic.

On Sun, Jan 23, 2022, 12:17 chasingkirkjufell @.***> wrote:

i thought that each dotnav can only have one subdomain? so there wouldn't be subdomains

— Reply to this email directly, view it on GitHub https://github.com/navcoin/navcoin-core/pull/916#issuecomment-1019410961, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIDAKL2B6TKTJUUWQJ3WZLUXN6M7ANCNFSM5MRYVYGQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

[chasingkirkjufell]

I can't resolve subdomain with true unless directly resolving subdomain. did i do it wrong? i'm on b8b7ff3 windows 10 gitian build

[mxaddict]

i thought that each dotnav can only have one subdomain? so there wouldn't be subdomains

Yes, we can't have second level subdomains, that is why we just ignore the subdomain request on a subdomain

[chasingkirkjufell]

In my screenshot I was trying to resolve first level subdomain with true on the original domain but it didnt work. Can only resolve subdomain directly.

[mxaddict]

I'll double check

[mxaddict]

@chasingkirkjufell I've fixed the issue that you mentioned

[navbuilder]

A new build of 555fa81aebc3516e48fd176b9fd1945ea0bc8a69 has completed succesfully! Binaries available at https://build.nav.community/binaries/add-resolvename-subdomains