navcoin / navcoin-core

bitcoin-core 0.13 fork ported for NavCoin
MIT License
123 stars 92 forks source link

Add listnames rpc method #924

Open sakdeniz opened 2 years ago

sakdeniz commented 2 years ago

Currently, there is no rpc method where we can see the list of registered names. I think it is necessary to add the listnames rpc method.

mxaddict commented 2 years ago

Just list all dotNAV names?

sakdeniz commented 2 years ago

List all dotNAV names with subdomains and key, value pairs like resolvename.

aguycalled commented 2 years ago

listing all the names with their entries can be a lot of data to transmit, might be better to only do it with the names imo

sakdeniz commented 2 years ago

So, its better to add mine parameter for filtering user owned domains or restrict method to only user owned domains with their entries.

aguycalled commented 2 years ago

I think even with the filter, it is more efficient to only show the names, letting the client to later resolve individually if needed.

sakdeniz commented 2 years ago

If it's going to be a serious performance issue, what you said might make sense. It would be better to be able to get all domains and subdomains information at once if there is no delay.

mxaddict commented 2 years ago

@sakdeniz I'm working on this now along side the nftindex

prashantbarge22 commented 2 years ago

If it's going to be a serious performance issue, what you said might make sense. It would be better to be able to get all domains and subdomains information at once if there is no delay.

Might be a solution Why don't maintain a cookie in the local Storage in the client, and regularly update it after a interval?

mxaddict commented 2 years ago

This patch has been updated to only list your own domains/subdomains, so it won't be too many to list.

prashantbarge22 commented 2 years ago

This patch has been updated to only list your own domains/subdomains, so it won't be too many to list.

Can you please help me with starting this project in windows as i am unable to do it

mxaddict commented 2 years ago

I'm not sure windows will be a good Idea for compiling this project, I would suggest running a linux VM.

I would suggest either VM Ware Player or Virtual Box, then install Ubuntu 20.04