search

navcoin / navcoin-core

bitcoin-core 0.13 fork ported for NavCoin
MIT License
123 stars 92 forks source link

Improved the response logging for curl call to price info #928

Closed mxaddict closed 2 years ago

mxaddict commented 2 years ago

image

aguycalled commented 2 years ago

do we want to merge this or do we just want to get binaries from gitian so pclark can test it?

mxaddict commented 2 years ago

I think we should merge it as it will help with further debugging in the future if anyone else get's issues with the price info.

Or we can just use the build to help debug for pclark.

I'll leave it up to you.

aguycalled commented 2 years ago

how often would it print to the debug? it it's too often, then we should only debug when some flags are enabled in the config file (debug=prices, for example) if we wanted to merge

mxaddict commented 2 years ago

how often would it print to the debug? it it's too often, then we should only debug when some flags are enabled in the config file (debug=prices, for example) if we wanted to merge

I can move the logging to only run on errors, this would mean only printing to log file if something is wrong with the request.

I'll do it now.

mxaddict commented 2 years ago

@aguycalled I think we should merge this after the build, but I think it's ready for review

navbuilder commented 2 years ago

A new build of cc7a99cd56af89a4332347b1fb3c896001a92272 has completed succesfully! Binaries available at https://build.nav.community/binaries/improved-logging-for-price-info-response