navcoin / navcoin-core

bitcoin-core 0.13 fork ported for NavCoin
MIT License
123 stars 92 forks source link

Add nft index #936

Closed mxaddict closed 2 years ago

mxaddict commented 2 years ago

closes #919 closes #920

navbuilder commented 2 years ago

A new build of 3fe3737378e6bac899a72804f79271d134b6809c has completed succesfully! Binaries available at https://build.nav.community/binaries/mxaddict:add-nft-index

navbuilder commented 2 years ago

A new build of 3fe3737378e6bac899a72804f79271d134b6809c has completed succesfully! Binaries available at https://build.nav.community/binaries/mxaddict:add-nft-index

mxaddict commented 2 years ago

image

mxaddict commented 2 years ago

Also, what other params should we add to the utxo? currently only showing the hash.

navbuilder commented 2 years ago

A new build of b3d81e47ab587c9af3a61d29e4b5dc515d2f44c6 has completed succesfully! Binaries available at https://build.nav.community/binaries/mxaddict:add-nft-index

mxaddict commented 2 years ago

image

mxaddict commented 2 years ago

@chasingkirkjufell @sakdeniz once build for 4afb994 is done, I think you should give this a test :)

mxaddict commented 2 years ago

@aguycalled I've also added the (with_utxo) param to gettoken rpc

navbuilder commented 2 years ago

A new build of 532baf159139f3c6f8c27a91c35c53ae904a0279 has completed succesfully! Binaries available at https://build.nav.community/binaries/mxaddict:add-nft-index

navbuilder commented 2 years ago

A new build of 82f14bd7bf4f45e21b39600d9be335eff3f44bd2 has completed succesfully! Binaries available at https://build.nav.community/binaries/mxaddict:add-nft-index

chasingkirkjufell commented 2 years ago

from discord conversations it sounds like you're still working on this?

mxaddict commented 2 years ago

Yes, I'm moving some logic into stateview

On Thu, Feb 24, 2022, 13:02 chasingkirkjufell @.***> wrote:

from discord conversations it sounds like you're still working on this?

— Reply to this email directly, view it on GitHub https://github.com/navcoin/navcoin-core/pull/936#issuecomment-1049497123, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIDAKI4EX4J5M33EKBEDATU4W3WNANCNFSM5OMXNIRQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

navbuilder commented 2 years ago

A new build of dd3337ebcbef5cee3f595ff03c32ea12d081f2f8 has completed succesfully! Binaries available at https://build.nav.community/binaries/mxaddict:add-nft-index

mxaddict commented 2 years ago

Thanks

On Fri, Feb 25, 2022, 04:33 alex v. @.***> wrote:

@.**** commented on this pull request.

changes look good, will test tomorrow and report back

— Reply to this email directly, view it on GitHub https://github.com/navcoin/navcoin-core/pull/936#pullrequestreview-892965814, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIDAKL2UMCYAJAJJZVLXULU42IYVANCNFSM5OMXNIRQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

navbuilder commented 2 years ago

A new build of e2df75faa927ab1713c6b04d87275011e84d0b6c has completed succesfully! Binaries available at https://build.nav.community/binaries/mxaddict:add-nft-index

aguycalled commented 2 years ago
image

Invalidating a block does not return to the previous utxo

mxaddict commented 2 years ago

@aguycalled I'm checking on this now

mxaddict commented 2 years ago

Does invalidate block run DisconnectBlock?

mxaddict commented 2 years ago

@aguycalled what did you mean by this:

the daemon does not check for discrepancies between -nftindex and the local db state (for example, if the local db has a nft index but -nftindex=0 was specified)
navbuilder commented 2 years ago

A new build of 3183371b29daafc213f44f54eec973ebb950d91c has completed succesfully! Binaries available at https://build.nav.community/binaries/mxaddict:add-nft-index

navbuilder commented 2 years ago

A new build of 7681f54d3a786f142db9990604c8a690374ee2a7 has completed succesfully! Binaries available at https://build.nav.community/binaries/mxaddict:add-nft-index

navbuilder commented 2 years ago

A new build of cc4634ce5bd9bc7f6d3c8ecb4e45036bd670a1b3 has completed succesfully! Binaries available at https://build.nav.community/binaries/mxaddict:add-nft-index

navbuilder commented 2 years ago

A new build of 7c18569130b61d036fb1f3cea1527156fc906358 has completed succesfully! Binaries available at https://build.nav.community/binaries/mxaddict:add-nft-index

navbuilder commented 2 years ago

A new build of 32f1884aa322bd0e97ba64f49e58a8e0291de165 has completed succesfully! Binaries available at https://build.nav.community/binaries/mxaddict:add-nft-index

navbuilder commented 2 years ago

A new build of 3bcfbb579a1222996574c087624efb5e2b574bf9 has completed succesfully! Binaries available at https://build.nav.community/binaries/mxaddict:add-nft-index

navbuilder commented 2 years ago

A new build of 9dbbf583cf117a125fcd5f0a5898f2e3e4109be2 has completed succesfully! Binaries available at https://build.nav.community/binaries/mxaddict:add-nft-index

navbuilder commented 2 years ago

A new build of 6e1f7edbe92a0779d5cbc377a13b07d1534c87d0 has completed succesfully! Binaries available at https://build.nav.community/binaries/mxaddict:add-nft-index

navbuilder commented 2 years ago

A new build of bb1adde3e9933af2d79b11a4b602abb8883a9ba5 has completed succesfully! Binaries available at https://build.nav.community/binaries/mxaddict:add-nft-index