navcoin / navcoin-core

bitcoin-core 0.13 fork ported for NavCoin
MIT License
123 stars 92 forks source link

Add `listnames` RPC command for dotNav #937

Open mxaddict opened 2 years ago

mxaddict commented 2 years ago

closes #924

navbuilder commented 2 years ago

A new build of 763fb6f458cd2f618445cec34082914f65049863 has completed succesfully! Binaries available at https://build.nav.community/binaries/mxaddict:add-listnames-rpc-command

mxaddict commented 2 years ago

@aguycalled should I just create an index for the dotNav names like I did for nftindex?

aguycalled commented 2 years ago

@aguycalled should I just create an index for the dotNav names like I did for nftindex?

sounds good

mxaddict commented 2 years ago

Should I maybe add the name to the namerecords index?

aguycalled commented 2 years ago

I'd say modifying the current index would make current clients crash when they try to read it with a different structure, unless some kind of versioning is implemented. Might be better to have a different index.

mxaddict commented 2 years ago

Alright, makes sense.

On Sun, Feb 27, 2022, 01:03 alex v. @.***> wrote:

I'd say modifying the current index would make current clients crash when they try to read it with a different structure, unless some kind of versioning is implemented. Might be better to have a different index.

— Reply to this email directly, view it on GitHub https://github.com/navcoin/navcoin-core/pull/937#issuecomment-1052318702, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIDAKOXJ7UDOWBGWHZJEY3U5EBVBANCNFSM5OM247TA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

navbuilder commented 2 years ago

A new build of 4e587d351d7b5348ce98b01918b4affcf190e713 has completed succesfully! Binaries available at https://build.nav.community/binaries/mxaddict:add-listnames-rpc-command

navbuilder commented 2 years ago

A new build of e32d6891aca2bbb540c329abc6c1db381619c0ef has completed succesfully! Binaries available at https://build.nav.community/binaries/mxaddict:add-listnames-rpc-command

navbuilder commented 2 years ago

A new build of 292766912acdb0399720c87d98647f2c068c6338 has completed succesfully! Binaries available at https://build.nav.community/binaries/mxaddict:add-listnames-rpc-command

navbuilder commented 2 years ago

A new build of d9ba894efca66b22e7b64de99e1dcbedb7e3b208 has completed succesfully! Binaries available at https://build.nav.community/binaries/mxaddict:add-listnames-rpc-command

navbuilder commented 2 years ago

A new build of 455710a51f14f406f29acaf689984d96c4025592 has completed succesfully! Binaries available at https://build.nav.community/binaries/mxaddict:add-listnames-rpc-command

navbuilder commented 2 years ago

A new build of 61fa02a5c9df9340c7f50ec87ef281408bae55c4 has completed succesfully! Binaries available at https://build.nav.community/binaries/mxaddict:add-listnames-rpc-command

navbuilder commented 2 years ago

A new build of 764485510b3360f94abc77dcb95d6f94593f69e0 has completed succesfully! Binaries available at https://build.nav.community/binaries/mxaddict:add-listnames-rpc-command

navbuilder commented 2 years ago

A new build of b1f43841aab05d62ac16cbe3287ddb156f0b9eaf has completed succesfully! Binaries available at https://build.nav.community/binaries/mxaddict:add-listnames-rpc-command

chasingkirkjufell commented 2 years ago

after i got this error and pressed ok after starting with -nameindex=0 and then switched to -nameindex=1 image i got another error image i thought the message means it'll reindex once i press ok. do i still need to set it? i seem to recall it reindex for me for token index.

further more, after i set -reindex-chainstate=1, i still get the same errors as above

mxaddict commented 2 years ago

after i got this error and pressed ok after starting with -nameindex=0 and then switched to -nameindex=1 image i got another error image i thought the message means it'll reindex once i press ok. do i still need to set it? i seem to recall it reindex for me for token index.

further more, after i set -reindex-chainstate=1, i still get the same errors as above

It should have rebuild the index, what does the debug.log say?

mxaddict commented 2 years ago

@chasingkirkjufell I think I know what happened

  1. You started wallet with -nameindex=1 (Clicked ok on the error)
  2. You restarted wallet with -nameindex=0 (You got the error again since you wanted to turn it off when it was already on)

Do you think this might have been the case?

chasingkirkjufell commented 2 years ago

@mxaddict once i set index to true, i cannot start the wallet no matter what.


2022-03-16 01:13:58 InitBlockIndex: nft index disabled
2022-03-16 01:13:58 InitBlockIndex: name index enabled
2022-03-16 01:13:58 InitBlockIndex: address index disabled
2022-03-16 01:13:58 InitBlockIndex: timestamp index disabled
2022-03-16 01:13:58 InitBlockIndex: spent index disabled
2022-03-16 01:13:58 Initializing databases...
2022-03-16 01:13:59 GUI: initializeResult : Initialization result:  0
2022-03-16 01:13:59 GUI: requestShutdown : Requesting shutdown
2022-03-16 01:13:59 GUI: shutdown : Running Shutdown in thread
2022-03-16 01:13:59 Interrupting HTTP server
2022-03-16 01:13:59 Interrupting HTTP RPC server
2022-03-16 01:13:59 Interrupting RPC
2022-03-16 01:13:59 scheduler thread interrupt
2022-03-16 01:13:59 PrepareShutdown: In progress...
2022-03-16 01:13:59 Stopping HTTP RPC server
2022-03-16 01:13:59 Stopping RPC
2022-03-16 01:13:59 Stopping HTTP server
2022-03-16 01:13:59 Stopped HTTP server
2022-03-16 01:13:59 StopNode()
2022-03-16 01:13:59 Committing 0 changed transactions (out of 0) to coin database...
2022-03-16 01:13:59 Shutdown: done
2022-03-16 01:13:59 GUI: shutdown : Shutdown finished
2022-03-16 01:13:59 GUI: shutdownResult : Shutdown result:  1
2022-03-16 01:13:59 GUI: ~NavcoinApplication : Stopping thread
2022-03-16 01:13:59 GUI: ~NavcoinApplication : Stopped thread```
mxaddict commented 2 years ago

Is this on windows?

On Wed, Mar 16, 2022, 09:16 chasingkirkjufell @.***> wrote:

@mxaddict https://github.com/mxaddict once i set index to true, i cannot start the wallet no matter what.

2022-03-16 01:13:58 InitBlockIndex: nft index disabled 2022-03-16 01:13:58 InitBlockIndex: name index enabled 2022-03-16 01:13:58 InitBlockIndex: address index disabled 2022-03-16 01:13:58 InitBlockIndex: timestamp index disabled 2022-03-16 01:13:58 InitBlockIndex: spent index disabled 2022-03-16 01:13:58 Initializing databases... 2022-03-16 01:13:59 GUI: initializeResult : Initialization result: 0 2022-03-16 01:13:59 GUI: requestShutdown : Requesting shutdown 2022-03-16 01:13:59 GUI: shutdown : Running Shutdown in thread 2022-03-16 01:13:59 Interrupting HTTP server 2022-03-16 01:13:59 Interrupting HTTP RPC server 2022-03-16 01:13:59 Interrupting RPC 2022-03-16 01:13:59 scheduler thread interrupt 2022-03-16 01:13:59 PrepareShutdown: In progress... 2022-03-16 01:13:59 Stopping HTTP RPC server 2022-03-16 01:13:59 Stopping RPC 2022-03-16 01:13:59 Stopping HTTP server 2022-03-16 01:13:59 Stopped HTTP server 2022-03-16 01:13:59 StopNode() 2022-03-16 01:13:59 Committing 0 changed transactions (out of 0) to coin database... 2022-03-16 01:13:59 Shutdown: done 2022-03-16 01:13:59 GUI: shutdown : Shutdown finished 2022-03-16 01:13:59 GUI: shutdownResult : Shutdown result: 1 2022-03-16 01:13:59 GUI: ~NavcoinApplication : Stopping thread 2022-03-16 01:13:59 GUI: ~NavcoinApplication : Stopped thread```

— Reply to this email directly, view it on GitHub https://github.com/navcoin/navcoin-core/pull/937#issuecomment-1068626193, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIDAKI72QLWPUZNAXN7XGTVAEY53ANCNFSM5OM247TA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

chasingkirkjufell commented 2 years ago

yep

navbuilder commented 2 years ago

A new build of 1cf3fcf5cc608a25d68a8ebe9dfca5aa86736d07 has completed succesfully! Binaries available at https://build.nav.community/binaries/mxaddict:add-listnames-rpc-command

chasingkirkjufell commented 2 years ago

@mxaddict still the same error i'm running navcoi-qt with -nameindex=0 fresh devnet folder. no issues so far switch to -nameindex=1, the window popped up saying needing to reindex chainstate, do i want to do it now? clicked okay, got the error saying need to do reindex again then wallet shuts down (the wallet should be doing reindexing now since i clicked okay and this is the behavior for other index i believe) now keep -nameindex=1 and add -reindex-chainstate, open wallet, same error and wallet shuts down after clicking the oks.

mxaddict commented 2 years ago

I see, will test it out

navbuilder commented 2 years ago

A new build of 33fb6116b72d55d3ca322f92d34297a6427b2a4e has completed succesfully! Binaries available at https://build.nav.community/binaries/mxaddict:add-listnames-rpc-command

navbuilder commented 2 years ago

A new build of 14dc474155bc1f9c8302e2ffeb529680a482a171 has completed succesfully! Binaries available at https://build.nav.community/binaries/mxaddict:add-listnames-rpc-command

navbuilder commented 2 years ago

A new build of 6cd2b4d56fa2ac19297dc1265c0f136fb0e09e59 has completed succesfully! Binaries available at https://build.nav.community/binaries/mxaddict:add-listnames-rpc-command

navbuilder commented 2 years ago

A new build of 5e7370a71f1be6d1aab024ff116501e54fd5fda2 has completed succesfully! Binaries available at https://build.nav.community/binaries/mxaddict:add-listnames-rpc-command

navbuilder commented 2 years ago

A new build of 5e7370a71f1be6d1aab024ff116501e54fd5fda2 has completed succesfully! Binaries available at https://build.nav.community/binaries/mxaddict/navcoin-core:add-listnames-rpc-command