search

naveednajam / Little-Snitch---Rule-Groups

This repo provide rule groups for Little Snitch based on unified host list to block ads, malware, fake news and porn
GNU General Public License v3.0
327 stars 38 forks source link

First splitfile always corrupt #3

Closed Madd33n closed 5 years ago

Madd33n commented 5 years ago

Hi, thanks for your script. Sadly there seems to be a little bug in the first splitted file "stevenblack0.lsrules". When importing this rule to the subscription, LittleSnitch pops up with an error.

I'm using LS at german language, so I just made a simple translation of the error.

"The file could not be opened due to a wrong format" I provided the screenshot and the corrupt file as well.

All other splitted files (stevenblack1 to stevenblack7) dont have this problem. Import works flawlessly. Can you please review the output and provide a bug fix?

Thanks. bildschirmfoto 2018-12-31 um 16 02 00 stevenblack0.lsrules.zip

naveednajam commented 5 years ago

Hi Madd33n, thanks for highlighting this issue, Format issue is caused by inline comment tags in steventblack hostfile. I updated the script to handle inline comment for domains and uploaded new rulesets. Can you try again to import first rule and feedback the result.Thanks

Madd33n commented 5 years ago

Hi,

thanks for the quick fix. Now, the first splitted file can be imported without any problem.

I also have a little request after using your script - maybe you can help :) I want to describe it in the "pull request" section, but i cant open a request.

So I'll describe it at another topic within the issues section.

Have a nice day.

naveednajam commented 5 years ago

Thanks for confirmation.I will close this issue now.