search

naveenkumarr05 / weather-app

0 stars 0 forks source link

cityWeatherReport #15

Open Oksana13 opened 2 years ago

Oksana13 commented 2 years ago

At least this condition should be extracted outside and re-used. Unfortunately it's still unclear for me, what is 'cityWeatherReport' string means, probably, naming should be improved a bit

https://github.com/naveenkumarr05/weather-app/blob/89bbedf3d4fd693a7f39c6db777a1ad077478127/src/components/DayForecastView.vue#L39

naveenkumarr05 commented 2 years ago

This condition is used for when User not giving any city in field and trying click CURRENT and 7 DAYS FORECAST buttons then it will show alert like Enter city name to search. Because initially we don't have city information. So cityWeatherReport this will be update when API call is done means should enter city and get response from API.