bug in getRotation() - Githubissues

naver / android-imagecropview

android image crop library

Apache License 2.0

254 stars 55 forks source link

Open out0 opened 5 years ago

out0 commented 5 years ago

Your getRotation() is always returning 0, when it should call super to return view's getRotation or just be deleted.

This bug prevent your view from correctly calculate rotation, therefore no rotation back to 0 degrees is possible.

just remove getRotation() override and things should go back to normal I guess

helloyako commented 5 years ago

I don't think so. This library doesn't provide rotation feature.

isabsent commented 4 years ago

Nice lib, thanks! Are you planning to support rotation?

helloyako commented 4 years ago

@isabsent Thank you. I don't have plan to support rotation now. But I think it's good idea if this lib support rotation. I will consider that.

jackyhieu1211-hn commented 4 years ago