naver / android-imagecropview

android image crop library
Apache License 2.0
254 stars 55 forks source link

Get and apply multiple crop information #51

Closed seki-tb closed 4 years ago

seki-tb commented 4 years ago

when i use saveState to save the second crop information, the first saved state will be changed. it can only save one state.

i found version 1.1.0 works well to save multiple crop information. and i also want to use outsideLayerColor attrs which is released in version 1.2.2? (so i can't use version 1.1.0) can those method in 1.1.0 be usable again in future?

https://github.com/naver/android-imagecropview/issues/10 https://github.com/naver/android-imagecropview/pull/11

helloyako commented 4 years ago

@seki-tb Thank you for your PR. I'm sorry. I don't know why this code has been removed.

helloyako commented 4 years ago

@seki-tb I deployed 1.2.4-SNAPSHOT to snapshot repository. Can you test in SNAPSHOT repository? If you don't have any problems, I will deploy 1.2.4 to release depository.

snapshot version from maven

repositories {
    maven { url "https://oss.sonatype.org/content/repositories/snapshots" }
}
dependencies {
   implementation 'com.naver.android.helloyako:imagecropview:1.2.4-SNAPSHOT'
}
seki-tb commented 4 years ago

@helloyako i tested in 1.2.4-SNAPSHOT, it works well. thank you very much !!!

helloyako commented 4 years ago

@seki-tb I released 1.2.4 just now. You can check this in 2 ~ 3 hours. Thank you