Migrate from java to kotlin in imagecropview module except ImageCropView

naver / android-imagecropview

android image crop library

Apache License 2.0

254 stars 55 forks source link

Migrate from java to kotlin in imagecropview module except ImageCropView #56

Closed NeoMindStd closed 3 years ago

NeoMindStd commented 3 years ago

Upgrade versions of gradle and kotlin
Delete ApplicationTest.java in androidTest
[x] Build and run success

helloyako commented 3 years ago

This is the highest priority in my mind. but I haven't do that yet :( Actuallty, I don't know kotlin well now. So I will just check build and basic function and then merge that.

Thank you so much for this PR :)

helloyako commented 3 years ago

@NeoMindStd I've tried test but zoom in/out is not working. It's serious problem. Could you check this?

NeoMindStd commented 3 years ago

@helloyako Sure, I'll check it.

NeoMindStd commented 3 years ago

@helloyako Sure, I'll check it.

I checked the problem you mentioned, and it happened to me too. I tried to solve the problem, but it was not resolved. so I exclude ImageCropView, and forced push the commit 01ef1b0a06b22aa22787545a5b531944f3a0f139.